Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all pages say they were edited on the same date #160

Closed
ix0rai opened this issue Sep 19, 2023 · 6 comments · Fixed by #164
Closed

all pages say they were edited on the same date #160

ix0rai opened this issue Sep 19, 2023 · 6 comments · Fixed by #164
Labels
bug Something isn't working

Comments

@ix0rai
Copy link
Member

ix0rai commented Sep 19, 2023

examples:
image
image
image

this is. well. incorrect
nothing else to say

@ix0rai ix0rai added the bug Something isn't working label Sep 19, 2023
@obj-obj
Copy link
Member

obj-obj commented Sep 19, 2023

Yeah I'm pretty sure it just uses the date of the latest git commit instead of the time that specific page was edited

@Akarys42
Copy link
Contributor

It is because the workflow is now using upstream checkout action for some reason? It doesn't unpack the git data correctly, which is why the fork was used. No idea why it was changed.

Commit responsible for this: b9428ae

@Southpaw1496
Copy link
Contributor

Southpaw1496 commented Sep 19, 2023

I changed it because I couldn't find any source code to see what it did, and I didn't like the idea of using a closed-source action in our pipeline that could change at any time.

(I searched for akarys42/checkout-with-filter on GitHub and found no results).

@Akarys42
Copy link
Contributor

@Southpaw1496
Copy link
Contributor

Southpaw1496 commented Sep 19, 2023

I blame GitHub search
Screenshot of GitHub search screen with no results.

@Southpaw1496
Copy link
Contributor

#164 should fix it

@Southpaw1496 Southpaw1496 linked a pull request Sep 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants