Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing images in the repo (tracking issue) #9

Open
triphora opened this issue Feb 24, 2022 · 2 comments
Open

Optimizing images in the repo (tracking issue) #9

triphora opened this issue Feb 24, 2022 · 2 comments

Comments

@triphora
Copy link

triphora commented Feb 24, 2022

As was mentioned on #8:

I think that's a fairly solid point - however, I'm not sure it's that useful to manually compress/optimise them via a PR. It'd be better if we could automate this somehow - any ideas?

We could setup a github action workflow that compresses any new image, I guess. I think what we should be looking at is having smaller copies of the same image though, like some 64x64 and 128x128.

I've had this in my notifications inbox for three months now and I don't want this to fade into obscurity, so here's a tracking issue to get the ball rolling in terms of discussion.

@Akarys42
Copy link
Contributor

Akarys42 commented Feb 24, 2022

After giving it more thoughts, I think it would be best to have a pre-commit compressing and downscaling images, and GitHub Actions checking that it has been ran.

This way we can make sure no unoptimized images or images without downscale are being committed.

That said, I still would like to reiterate that a repository like this will be massive to download. Git isn't made for such data. Suggesting shallow clones to be made (one that lazily fetches older revisions, so effectively only the last version of each file is downloaded ahead of time) would in my opinion be more sensible.

@KTibow
Copy link

KTibow commented Mar 8, 2022

Random guy here with absolutely no context; I think one easy option might be imgbot. Yes, it does create a new PR, but it's mostly automatic, and only triggers when something relevant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants