-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git options #25
Comments
You probably already know this, but I don't have a big problem with using subprocess to do this, however, we should make sure to use the pluming functionality, rather than the porcelain. |
Dulwich seems to still be in development. There is a Python 3 branch, but the creators have said that it has some issues. Personally, my desired order would be Dulwich, libgit2, then subprocess. In-memory operations are way better than actually checking out files and reading off the disk. Dulwich seems like it might not be ready for use, and I have no problem requiring people to build libgit2. The old Qcumber does this already with I don't like subprocess at all. It's a huge hack and will most likely cause problems down the line. Plus, it also requires installation, much like libgit2. That being said, it's probably the easiest so if you want to just get it working and don't mind re-implementing later, go for it. Casting my vote for pygit2 + libgit2. |
I will give pygit2 + libgit2 a try. |
Sounds awesome
|
so dulwich is feature lacking(no push, branches are nightmare) and is not python 3 compatible
libgit2 has a bunch of dependencies and is difficult to install
subprocess is "bad"
but how "bad" is subprocess? are there other preferred options? I think that with dulwich we'll end up half using subprocess anyways and/or end up spending delevopment time on dulwich instead of qcumber (the main goal)
The text was updated successfully, but these errors were encountered: