Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git options #25

Open
Graham42 opened this issue Jan 29, 2014 · 4 comments
Open

Git options #25

Graham42 opened this issue Jan 29, 2014 · 4 comments

Comments

@Graham42
Copy link
Contributor

so dulwich is feature lacking(no push, branches are nightmare) and is not python 3 compatible

libgit2 has a bunch of dependencies and is difficult to install

subprocess is "bad"

but how "bad" is subprocess? are there other preferred options? I think that with dulwich we'll end up half using subprocess anyways and/or end up spending delevopment time on dulwich instead of qcumber (the main goal)

@mystor
Copy link
Member

mystor commented Jan 29, 2014

You probably already know this, but I don't have a big problem with using subprocess to do this, however, we should make sure to use the pluming functionality, rather than the porcelain.

@pR0Ps
Copy link
Member

pR0Ps commented Jan 29, 2014

Dulwich seems to still be in development. There is a Python 3 branch, but the creators have said that it has some issues.

Personally, my desired order would be Dulwich, libgit2, then subprocess. In-memory operations are way better than actually checking out files and reading off the disk. Dulwich seems like it might not be ready for use, and I have no problem requiring people to build libgit2. The old Qcumber does this already with lxml (it's a C implementation that requires gcc + libraries to compile when you pip install it).

I don't like subprocess at all. It's a huge hack and will most likely cause problems down the line. Plus, it also requires installation, much like libgit2. That being said, it's probably the easiest so if you want to just get it working and don't mind re-implementing later, go for it.

Casting my vote for pygit2 + libgit2.

@Graham42
Copy link
Contributor Author

I will give pygit2 + libgit2 a try.

@mystor
Copy link
Member

mystor commented Jan 31, 2014

Sounds awesome
On Jan 31, 2014 8:40 AM, "Graham42" [email protected] wrote:

I will give pygit2 + libgit2 a try.

Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-33794380
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants