Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas_price() estimate function may not return expected value for multi-native token #848

Open
qizhou opened this issue Mar 17, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@qizhou
Copy link
Contributor

qizhou commented Mar 17, 2020

def gas_price(self, token_id: int) -> Optional[int]:

The current estimation will estimate based on the historical gas price of the same token id, which may be empty or small if the token id is not frequently used. A better way may still estimate the price for QKC first and then convert to the price for token id.

Further, returning MIN_TX_POOL_GAS_PRICE for other token ids other than QKC may be wrong.

@qizhou
Copy link
Contributor Author

qizhou commented Mar 20, 2020

We may also need to add a jsonrpc that accepts:

  • chain id
  • token id
  • gas price
    and outputs
  • gas price in QKC

@ninjaahhh ninjaahhh added the enhancement New feature or request label Mar 23, 2020
@ninjaahhh
Copy link
Contributor

lower the priority since it's not consensus-critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants