Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chain mask list for slave-shard relationship #826

Open
ninjaahhh opened this issue Feb 24, 2020 · 3 comments · Fixed by #831
Open

Fix chain mask list for slave-shard relationship #826

ninjaahhh opened this issue Feb 24, 2020 · 3 comments · Fixed by #831
Assignees
@lyhe18
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ninjaahhh
Copy link
Contributor

as of now our config is still using chain mask list to configure shard-slave mapping:

    """ Represent a mask of chains, basically matches all the bits from the right until the leftmost bit is hit.
    E.g.,
    mask = 1, matches *
    mask = 0b10, matches *0
    mask = 0b101, matches *01
    """

however it doesn't fit our current chain/shard ID decoding. we should migrate the chain mask list to be a list of full shard IDs indicating exactly what shards a slave should run.
@ninjaahhh ninjaahhh added enhancement New feature or request good first issue Good for newcomers labels Feb 24, 2020
@ninjaahhh ninjaahhh assigned FreshmanQ and lyhe18 and unassigned FreshmanQ Feb 24, 2020
@ninjaahhh
Copy link
Contributor Author

@lyhe18 can you take this task?

@lyhe18
Copy link
Contributor

lyhe18 commented Feb 25, 2020

No problem~

@hanyunx hanyunx linked a pull request Feb 28, 2020 that will close this issue
Migrate chain mask list config to full shard id list #831
Merged
@lyhe18
Copy link
Contributor

lyhe18 commented Mar 3, 2020

This issue is linked to #831

@lyhe18 lyhe18 mentioned this issue Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyhe18 lyhe18

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate chain mask list config to full shard id list QuarkChain/pyquarkchain
3 participants
@ninjaahhh @lyhe18 @FreshmanQ