Skip to content
This repository has been archived by the owner on Jun 4, 2020. It is now read-only.

PR's from external users can't fetch the Private QuantEcon themes #64

Closed
1 task
mmcky opened this issue May 7, 2020 · 3 comments
Closed
1 task

PR's from external users can't fetch the Private QuantEcon themes #64

mmcky opened this issue May 7, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@mmcky
Copy link
Contributor

mmcky commented May 7, 2020

When a PR is raised by an external user (i.e. not QuantEcon python-lectures access team list) the private theme is not able to be fetched in Github Actions.

  • figure out how to specify a user for fetching the theme files for previews.

QuantEcon/lecture-python-advanced#120
@mmcky
Copy link
Contributor Author

mmcky commented May 7, 2020

actions/checkout#221

@mmcky
Copy link
Contributor Author

mmcky commented May 7, 2020

actions/checkout#13

@mmcky mmcky added the bug Something isn't working label May 8, 2020
@mmcky
Copy link
Contributor Author

mmcky commented May 19, 2020

This can't be done as a fork will never have credentials for netlify deploys and previews.

I have added artifacts in the meantime when a fork is build so the html files could be downloaded and checked. QuantEcon/lecture-python#218

@mmcky mmcky closed this as completed May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmcky