Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Brokerage Repo Readmes #1575

Open
3 tasks done
DerekMelchin opened this issue Jan 12, 2024 · 1 comment
Open
3 tasks done

Review Brokerage Repo Readmes #1575

DerekMelchin opened this issue Jan 12, 2024 · 1 comment

Comments

@DerekMelchin
Copy link
Collaborator

DerekMelchin commented Jan 12, 2024

Expected Behavior

The brokerage repo readmes (example) have up-to-date information and all links are functional

Actual Behavior

These brokerage repo readmes fall out-of-date over time. For example, one of the terminal outputs on the Coinbase repo includes brokerages that we don't even support anymore.

    $ lean live 'My Project'
     
    Select a brokerage:
    1. Paper Trading
    2. Interactive Brokers
    3. Tradier
    4. OANDA
    5. Bitfinex
    6. Coinbase Pro
    7. Binance
    8. Zerodha
    9. Samco
    10. Terminal Link
    11. Atreyu
    12. Trading Technologies
    13. Kraken
    14. FTX
    Enter an option: 

The Coinbase repo even includes steps in the deployment process that are no longer required. For example, the deployment wizard support existing holdings now, but the repo doesn't reflect this.

Moreover, the readmes have broken links. We should extend the automated link checker to scan the links on these brokerage/dataset repos.

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
@DerekMelchin
Copy link
Collaborator Author

We can extend this to the DataSource repos too. All of these links

See Tutorials for a step by step guide for creating a new LEAN Data Source.

in those repos return a 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants