Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate in 1.4 the pending deprecations from the 1.* cycle #13589

Open
1ucian0 opened this issue Dec 20, 2024 · 1 comment
Open

Deprecate in 1.4 the pending deprecations from the 1.* cycle #13589

1ucian0 opened this issue Dec 20, 2024 · 1 comment
Labels
type: epic A theme of work that contain sub-tasks
Milestone

Comments

@1ucian0
Copy link
Member

1ucian0 commented Dec 20, 2024

The following functions/methods/classes are annotated as pending deprecations (probably, because the alternative was introduced in the same release):

1.1: #13601

  • qiskit/visualization/pulse_v2/interface.py:35 (draw)
  • qiskit/visualization/timeline/interface.py:33 (draw)
  • qiskit/visualization/timeline/interface.py:34 (draw)
  • qiskit/pulse/schedule.py:1696 (draw)

1.2: #13603

  • qiskit/synthesis/evolution/suzuki_trotter.py:61 (__init__)
  • qiskit/synthesis/evolution/qdrift.py:44 (__init__)
  • qiskit/synthesis/evolution/product_formula.py:45 (__init__)

1.3: #13604

  • qiskit/circuit/library/hidden_linear_function.py:71 (__init__)
  • qiskit/circuit/library/graph_state.py:60 (__init__)
  • qiskit/circuit/library/iqp.py:65 (__init__)
  • qiskit/circuit/library/fourier_checking.py:56 (__init__)
  • qiskit/circuit/library/phase_estimation.py:52 (__init__)
  • qiskit/circuit/library/overlap.py:62 (__init__)
  • qiskit/circuit/library/grover_operator.py:426 (__init__)
  • qiskit/circuit/library/generalized_gates/diagonal.py:37 (__init__)
  • qiskit/circuit/library/generalized_gates/linear_function.py:229 (synthesize)
  • qiskit/circuit/library/generalized_gates/permutation.py:31 (__init__)
  • qiskit/circuit/library/generalized_gates/gms.py:80 (__init__)
  • qiskit/circuit/library/generalized_gates/mcmt.py:52 (__init__) Deprecation of MCMT in favor of MCMTGate #13584
  • qiskit/circuit/library/generalized_gates/mcmt.py:159 (__init__) Deprecation of MCMT in favor of MCMTGate #13584
  • qiskit/circuit/library/basis_change/qft.py:75 (__init__)
  • qiskit/circuit/library/data_preparation/pauli_feature_map.py:410 (__init__)
  • qiskit/circuit/library/data_preparation/_zz_feature_map.py:98 (__init__)
  • qiskit/circuit/library/data_preparation/_z_feature_map.py:78 (__init__)
  • qiskit/circuit/library/boolean_logic/quantum_xor.py:32 (__init__)
  • qiskit/circuit/library/boolean_logic/quantum_and.py:54 (__init__)
  • qiskit/circuit/library/boolean_logic/inner_product.py:65 (__init__)
  • qiskit/circuit/library/boolean_logic/quantum_or.py:55 (__init__)
  • qiskit/circuit/library/arithmetic/adders/adder.py:45 (__init__)
  • qiskit/circuit/library/arithmetic/multipliers/multiplier.py:49 (__init__)
  • qiskit/circuit/library/standard_gates/x.py:1174 (get_num_ancilla_qubits)
  • qiskit/circuit/library/standard_gates/x.py:1286 (__init__)
  • qiskit/circuit/library/standard_gates/x.py:1341 (__init__)
  • qiskit/circuit/library/standard_gates/x.py:1431 (__init__)
  • qiskit/circuit/library/n_local/n_local.py:306 (__init__)
  • qiskit/circuit/library/n_local/efficient_su2.py:194 (__init__)
  • qiskit/circuit/library/n_local/real_amplitudes.py:236 (__init__)
  • qiskit/circuit/library/n_local/pauli_two_design.py:170 (__init__)
  • qiskit/circuit/library/n_local/excitation_preserving.py:215 (__init__)
  • qiskit/circuit/library/n_local/two_local.py:140 (__init__)

They should be moved to deprecations in 1.4 (not all of them need to be removed in 2.0).

@1ucian0 1ucian0 added the type: epic A theme of work that contain sub-tasks label Dec 20, 2024
@1ucian0 1ucian0 added this to the 1.4.0 milestone Dec 20, 2024
@Cryoris
Copy link
Contributor

Cryoris commented Dec 20, 2024

We need to discuss whether we want to remove the circuit library objects for 2.0 -- I think the sentiment currently is to keep them for the 2.* cycle, since they were heavily used and we might want to allow for a longer grace period before removing them fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: epic A theme of work that contain sub-tasks
Projects
None yet
Development

No branches or pull requests

2 participants