You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As new contributions are coming into the project, it would be good to formalize the formatting style and expectations for the project, and for that it would probably a good idea to add Prettier to the project.
I opted to incorporate husky for managing pre-commit hooks, but I am OK if we just want to just have it so contributors manually run prettier format locally.
Either way, we should still have prettier format run on CI as part of our GitHub Actions flow
We should probably also upgrade to ESLint to the latest version and make sure it has any prettier overlapping rules disabled. Here's that's project's ESLint config for reference (we don't need the markdown configuration though)
We should add a note to the CONTRIBUTING.md with whatever workflow we end up with
Ok, great. Yes, definitely up for helping with this but agree that we can wait until we get all of the other good stuff we've been talking about in there
Type of Change
Chore
Summary
As new contributions are coming into the project, it would be good to formalize the formatting style and expectations for the project, and for that it would probably a good idea to add Prettier to the project.
There's an example we can follow from the Greenwood website that I implemented that we can follow
https://github.com/ProjectEvergreen/www.greenwoodjs.dev
Details
A couple notes regarding the above reference repo
prettier format
locally.prettier format
run on CI as part of our GitHub Actions flowAs we have a few PRs and release in active development, my recommendation would be to wait until all those PRs land first, or just do it as the first change once we cut the v0.16.0 release
https://github.com/ProjectEvergreen/wcc/issues?q=label%3A0.16.0+
The text was updated successfully, but these errors were encountered: