-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SAM2 (Inference only) as base model for all the apps #1777
Conversation
Signed-off-by: Sachidanand Alle <[email protected]>
for more information, see https://pre-commit.ci
|
Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
Signed-off-by: Sachidanand Alle <[email protected]>
Hi @SachidanandAlle! This is great work :) Did you also have a chance to test it (SAM2) with OHIF? Or do you work for it now? If not yet, but you have interest in, then maybe you can take a look my recent work. I enabled SAM2 at OHIF via Monai Label. |
Monailabel ohif v3 plugin is kind of in broken state. Work in progress to fix it to support all the previous functions of monailabel and keep it similar to 3D slicer. Once that is achieved, SAM 2D/3D versions will appear similar to monailabel deepgrow models for users to interact and annotate. ROI input may not be there initially (need to investigate how ohif supports bounding box). But feel free to help or add any missing options once RC2 with enhanced ohif plugin is released. Hopefully by next week. We need more contributions to make monailabel better and useful for everyone. Thanks for sharing the video. Very nice. Looking for more support and contributions for monailabel. |
@SachidanandAlle Thank you for the quick reply and straightforward answer :) I see. Yes, in the beginning, I tried to use all the models via monailabel panel at ohif, but I failed to use it. Instead, I decided to add a couple of buttons in the toolbar and invoke monailabel API directly. I still don't know how to use deepgrow and deepedit at OHIF. Therefore, I'm very interested in to reproduce them. I used several useful utilities and tools of Monailabel, but I passed many parts of MonaiLabel. It will be great if I have a chance to explain how I did it to you, therefore you can give me an advice how to use MonaiLabel and modify it properly. I'm already in contact with OHIF core team. Regarding my recent work, I had a call with them this Monday, and they explained their interest is more in integrating SAM/SAM2 in serverless way, like using Onnx/WebGPU resource. What I can bring it to MonaiLabel community is the updated Ohif (now 3.9 beta, but plan to upgrade it to recent one) with working SAM2 (points, bounding box prompts, 2D/3D inference) + multiple labels. But as I explained, it might look different in code level, which makes a bit challenging to ship it to your main branch. Do you have interest in collaboration with me? I'm working as PhD student at University Hospital Bonn, under the supervison, Prof. Philipp Vollmuth. My interest is somehow contributing MONAI Label repo with my work, and at the same time, I would like to understand it better. |
That's really helpful. Currently there is some work in progress to update the monailabel plugin based on latest ohifv3. Once the rc2 (hopefully in next week) is released. You can verify if basic (without ROI) works great for SAM2. And you can add your ideas (supporting ROI based) on top of that. You have definitely some cool ideas related to toolbard/roi etc.. you can help to enhance rc2 plugin based on the same. |
This is great to hear, @Joeycho |
Verified SAM2 for 3D Slicer (both 2D/3D), QuPath, CVAT plugins.