Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No randomness for threading=True #7922

Open
marcus-wirtz-snkeos opened this issue Jul 16, 2024 · 1 comment · May be fixed by #7925
Open

No randomness for threading=True #7922

marcus-wirtz-snkeos opened this issue Jul 16, 2024 · 1 comment · May be fixed by #7925

Comments

@marcus-wirtz-snkeos
Copy link

_transform = deepcopy(_transform) if isinstance(_transform, ThreadUnsafe) else _transform

When using threading=True, the random state of any Randomizable transformation is only updated within its copy, thus the original random state will be untouched generating the same samples over and over.

I already saw that somewhere in the docs there is a mentioning of "limited randomness" for threading (even though I find that a rather optimistic description). Are there plans how to tackle this issue? Or won't it be supported?

@marcus-wirtz-snkeos marcus-wirtz-snkeos linked a pull request Jul 17, 2024 that will close this issue
7 tasks
@marcus-wirtz-snkeos
Copy link
Author

I made a proposal in PR #7925 to fix this issue. Not sure whether it might have some other unwanted implications, so it would be nice to have a review from an experienced contributor 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant