Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Adding Office365DSC #501

Open
14 of 18 tasks
NikCharlebois opened this issue Apr 16, 2019 · 5 comments
Open
14 of 18 tasks

Adding Office365DSC #501

NikCharlebois opened this issue Apr 16, 2019 · 5 comments
Assignees

Comments

@NikCharlebois
Copy link
Contributor

NikCharlebois commented Apr 16, 2019

New resource module submission

**Name: Office365DSC

Repository URL: https://GitHub.com/Microsoft/Office365DSC

Short description: PowerShell Desired State Configuration module for Office 365

New resource module submission task list

This task list can be filled in after the issue has been submitted.

  • Pass the Quality Governance
  • Pull request is sent in (see next section).
  • The new module submission in ready for community review.

Steps that pull request should include

  • Added submodule using git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>.
  • Updated resource module list in Maintainers.md.

Community acceptance

The new resource module:

  • is licensed under MIT.
  • has the correct project structure.
  • has a dev and master branch, and dev should default branch.
  • is using DSC Resource Kit test templates.
  • is connected to Codecov or similar.
  • has established a code of conduct in ether a CODE_OF_CONDUCT.md or a
    'Code of conduct' section in the README.md.
  • has either a CONTRIBUTING.md file or a 'Contributing' section in the
    README.md file.
  • has included the metadata tag 'DSCResource' in the module manifest.
  • is sufficiently documented.
  • has an established CI process for each push to the repository.
  • is sufficiently tested.
  • Follows the guidelines set out for a
    High Quality Resource Module.

Submission acceptance

The community accepts, at a community call, that a resource module follows the
guidelines set out for a
High Quality Resource Module.

  • The resource module was accepted for submission in a community call.
@NikCharlebois
Copy link
Contributor Author

NikCharlebois commented Apr 16, 2019

Linked to PR #500

@johlju
Copy link
Contributor

johlju commented Apr 19, 2019

@NikCharlebois Could you please check the boxes above when they are resolved/compliant? I think most you have resolved.
Is it possible to add Codecov status badeges to your repo so we can see the code coverage? (maybe we should update the template with that?)

Unfortunately only the issue author and a collaborator can change the checkboxes (my hope was that all contributors could have checked them, when I added the template).

@johlju
Copy link
Contributor

johlju commented Apr 19, 2019

@gaelcolas do we have an agenda entry for module submissions in the community call? So we remember to raise these issues. I check and add an entry if there aren't any.

@gaelcolas
Copy link
Contributor

Please add change to the agenda file in this PR.

@johlju
Copy link
Contributor

johlju commented Apr 19, 2019

Agenda merged in another PR.

@gaelcolas gaelcolas self-assigned this Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants