Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Add GitHub App "Review Me" to DSC Resource Kit repositories #430

Open
johlju opened this issue Aug 7, 2018 · 3 comments
Open

Add GitHub App "Review Me" to DSC Resource Kit repositories #430

johlju opened this issue Aug 7, 2018 · 3 comments
Labels
enhancement The issue is an enhancement request. external The issue cannot be resolved within the DSC Resource Kit. on hold The issue or pull request has been put on hold by a maintainer.

Comments

@johlju
Copy link
Contributor

johlju commented Aug 7, 2018

I suggest we look at adding the GitHub App Review Me to all DSC Resource Kit repositories. It will help by adding the needs review tag when all the status checks are green.
One more step to automate maintainer repetitive tasks.

.github/review-me.yml

# Configuration for probot-review-me - https://github.com/z0al/probot-review-me
when:
  continuous-integration/appveyor/pr: success
  license/cla: success

label: needs review
@johlju johlju changed the title Add GitHUb App "Reveiew Me" to DSC Resource Kit repositories Add GitHub App "Reveiew Me" to DSC Resource Kit repositories Aug 7, 2018
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Aug 7, 2018
@johlju
Copy link
Contributor Author

johlju commented Aug 7, 2018

First out is the repository DscResource.Tests, to test the functionality in real scenarios.

@johlju johlju changed the title Add GitHub App "Reveiew Me" to DSC Resource Kit repositories Add GitHub App "Review Me" to DSC Resource Kit repositories Aug 7, 2018
@johlju
Copy link
Contributor Author

johlju commented Aug 7, 2018

Problems using Review Me (after real scenario tests):

Where the last one is the most serious one for our current workflow. It will set 'needs review' on every PR that has a 'waiting label'. I think we need to look at changing our workflow, or how the labels are used.

@johlju
Copy link
Contributor Author

johlju commented Aug 10, 2018

Uninstalled Review Me from DscResource.Tests for the time being due to the problems above. I have not remove the configuration file yet, I keep this issue open to see if we can get any improvements to the app, or a reminder to remove the configuration file before closing this issue.

@johlju johlju added external The issue cannot be resolved within the DSC Resource Kit. on hold The issue or pull request has been put on hold by a maintainer. and removed in progress The issue is being actively worked on by someone. external The issue cannot be resolved within the DSC Resource Kit. labels Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement The issue is an enhancement request. external The issue cannot be resolved within the DSC Resource Kit. on hold The issue or pull request has been put on hold by a maintainer.
Projects
None yet
Development

No branches or pull requests

1 participant