Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the mod names used [feature req.] + change default mod names for consistency #21

Open
Starwort opened this issue May 6, 2018 · 8 comments

Comments

@Starwort
Copy link

Starwort commented May 6, 2018

i.e. The standard modset is DT, HD, HR, HT. Kx, NC, NF, PF, RN, RX, RX2, SD, SO, TP.
I would like to rename RX to AP (as the mod it represents is autopilot) and RX2 to RL (which is my preference on the abbreviation); however, this appears to be impossible. Could this be added as a feature? (For both mod image names and !mods! output)

Thank you for reading,
Starwort

@Piotrekol
Copy link
Owner

Piotrekol commented May 6, 2018 via email

@Starwort
Copy link
Author

Starwort commented May 6, 2018 via email

@Starwort
Copy link
Author

Starwort commented May 6, 2018

All mods and any mistakes. (abbreviation) - taken from the wiki, [abbreviation] - not on the wiki.
osu!std:
Easy (EZ) - Correct!
NoFail (NF) - Correct!
Half Time (HT) - Correct!
Hard Rock (HR) - Correct!
Sudden Death (SD) - Correct!
Perfect (PF) - Correct!
SD is shown with PF - only PF should be shown
Double Time (DT) - Correct!
Nightcore (NC) - Correct!
DT is not shown with NC - Correct!
Hidden (HD) - Correct!
Flashlight (FL) - Correct!
Relax (RL) -> RX [but mod icon included is named "RX2"]
Autopilot (AP) -> RX2 [but mod icon included is "RX"]
Spun Out (SO) - Correct!
Auto (AU) -> AP
Cinema [CN] -> LM
AU is shown with CN - only CN should be shown
ScoreV2 [SV2] -> Not detected
Target Practice (TP) - Correct!
osu!mania:
Fade In (FI) - Correct!
x Keys (xK) -> Kx
Co-Op [CO] -> Coop
Random (RD) -> RN

I hope these can be fixed to be more consistent with the wiki :D

@Starwort Starwort changed the title Allow changing the mod names used [feature req.] Allow changing the mod names used [feature req.] + change default mod names for consistency May 6, 2018
@Piotrekol
Copy link
Owner

Piotrekol commented May 6, 2018

If you want to you could submit PR to CollectionManager repo with necessary changes for these mod names, If not I'll get to that later too.
All of these are defined(Except for missing ones with can be simply added there) in 2 files:
ModParser.cs
Mods.cs

@Starwort
Copy link
Author

Starwort commented May 7, 2018

IIRC NV isn't a mod any more, it's now touch device.

Piotrekol pushed a commit to Piotrekol/CollectionManager that referenced this issue May 10, 2018
* Fix abbreviation inconsistencies and add catches for PF+SD, CN+AU

* Add TP

TO -> TP

* Rename Ap=>Au; Lm=>Cm

* Add test for "hiding" of mod pairs

Piotrekol/StreamCompanion#21
@Piotrekol
Copy link
Owner

With these fixes in place, is this request still valid? (Would you still change any of the mods because of "preference"?)

@Starwort
Copy link
Author

I, personally, likely would not. I do, however, feel like this would be a good future feature if you have the time (sorry for late response, push notifications are not working correctly with GMail atm).
Thank you for taking the time to implement the fix.

@h3oCharles
Copy link

h3oCharles commented Dec 23, 2018

confirming that scorev2 isn't displaying in StreamCompanion v181221.22, here I was able to put together default mod icons.

Images.zip EDIT1: oops, rename RN to RD plz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants