Avoid error messages and occasional core dumps #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7.2) After patching our ancient joomla 1.5 installations with the current session hardening fix, we noticed the following error messages in the log files occur: Notice: Only variable references should be returned by reference in /srv/www/htdocs/sheep/libraries/joomla/session/session.php on line 343 On some instances running via apache/php/fcgi we encounter occasional core dumps. The change avoids the error message by assigning the result of the method call first to a variable and returning that variable. As a result the error messages are gone and the occasional core dumps did not occur anymore
level420
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After patching our ancient joomla 1.5 installations with the current session hardening fix, we noticed the following error messages in the log files occur:
Notice: Only variable references should be returned by reference in /srv/www/htdocs/sheep/libraries/joomla/session/session.php on line 343
On some instances running via apache/php/fcgi (apache 2.4, php 5.4.16, mod_fcgid) we encounter occasional core dumps.
The change avoids the error message by assigning the result of the method call first to a variable and returning that variable.
As a result the error messages are gone and the occasional core dumps did not occur anymore