Improvements to pat-date-picker to make it ready for inclusion into core.

[jcbrand]

Feedback from @cornae (euphorie/osha.oira#20)

I tried to limit date picker to only use date, not time. The readme advises pat-date-picker="show: date". This however didn't work, I still see time. Date only should also be the default. I could actually not imagine any use case in which I would prefer the time picker over trusted [ ]h [ ]m fields.

Some comments about the properties:

date
This one uses JSON as a value. Patterns don't use JSON to define options. We should translate this to formats that are easy to read and use by everybody.

separator
Default value missing

show
Fine syntax, but doesn't work.

behaviour
Fine, but — like in CSS — there should always be a counter value. Even if it's a fake one.

time
JSON it says. Totally unclear to me as a designer what to do here, how to use it or why I would need it.

timezone
Same as time.

I think the pattern is still too immature to be added to stock Patterns. Properties have to be designer proof first. I think I could have helped here, should I have been in involved with the design process of the properties.

I understand by reading the documentation that in the end, there was still chosen for pickadate as a base. Why was this? Which were the other condidates? I ask because I thought that at first we wanted to leave pickadate adn because the way the markup and the class names are set up is not ideal with this script.

[pilz]

@cornae We just tried to get to the bottom of what needs to be done. I just saw that ikath now has a date picker that is somewhat styled - has some issues - but seems to be well underways, so you got the "show: date" to work?

Is it correct that the only thing missing now is to specify separator and behaviour counter value, which you can just tell us and we'll add?

Then we will change the time attribute to support a different format. Can you specify what you would like to have best? Also how you would like to note the timezone please.

[cornae]

Op 10 jun. 2015 om 10:46 heeft Alexander Pilz [email protected] het volgende geschreven:

@cornae We just tried to get to the bottom of what needs to be done. I just saw that ikath now has a date picker that is somewhat styled - has some issues - but seems to be well underways, so you got the "show: date" to work?

No. It's still showing the time field too. And I have huge styling issues due to the fact that this script injects the picker in the Dom where the input is instead of at the end of the Dom tree.
Is it correct that the only thing missing now is to specify separator and behaviour counter value, which you can just tell us and we'll add?

Not sure. I haven't gotten it to work well enough in Safari (it disappears) or chrome to be able to tell.
Then we will change the time attribute to support a different format. Can you specify what you would like to have best? Also how you would like to note the timezone please.

No time zone. Just a date no time. There is no time in the design which is why I'm so desperately trying to let it not draw a field I didn't design.
—
Reply to this email directly or view it on GitHub.

[jcbrand]

No. It's still showing the time field too.

Because you had the wrong markup. See here: https://github.com/ploneintranet/ploneintranet.prototype/commit/9252fe43ce055bf72f5fca2649e2e8a382dc3dfb

And I have huge styling issues due to the fact that this script injects the picker in the Dom where the input is instead of at the end of the Dom tree.

Should I see if I can change it to be appended at the end of the DOM?