Substitute calls to convertMarkdownToHtml to MarkdownRenderer.render #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsa-ferreira
requested changes
Nov 24, 2024
| taskListRender.dataset["language"] = "hypermd"; | ||
| taskListRender.insertAdjacentHTML("afterbegin", convertMarkdownToHTML(this.template)); | ||
| MarkdownRenderer.render(this.app, this.template, taskListRender, "./", this.component); |
There was a problem hiding this comment.
Este component é o plugin em si, ou é impressão minha? não dava para o componente ser só o modal?
There was a problem hiding this comment.
Acho que nao. Que o Modal nao da inherit do tipo Component
There was a problem hiding this comment.
Modal implementa a interface ClosableComponent, mas nao é um Component pelo que percebi
| private app: App; | ||
| private taskifier: Taskifier | ||
| private editor: Editor; | ||
| private app: App; |
There was a problem hiding this comment.
isto está com 2 tabs ou é impressão minha?
There was a problem hiding this comment.
bem, montes de ficheiros parecem estar com 8 spaces tabs em vez de 4
There was a problem hiding this comment.
Acho que so tem 1 tab. E acho que sao 4 spaces
dsa-ferreira
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.