Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use log4j version 2.25.0-SNAPSHOT to solve Nashorn start-up issue #1468

Closed
wants to merge 1 commit into from

Conversation

kangarko
Copy link

@kangarko kangarko commented Dec 4, 2024

Fixes #1462

@kangarko
Copy link
Author

kangarko commented Dec 4, 2024

See apache/logging-log4j2#3125 for context, thank you very much for your consideration. I understand snapshot builds are not preferable but given the severity of this issue there is a good rational for using it temporarily.

@kangarko
Copy link
Author

kangarko commented Dec 4, 2024

The only downside are the warnings for which another issue at log4j has already been opened. They are purely warnings and can be ignored as confirmed by their developers.

@kangarko
Copy link
Author

kangarko commented Dec 7, 2024

@4drian3d can this be looked at and pulled? I noticed the thumbs down but this is a serious issue in any plugin using javascript placeholders

@electronicboy
Copy link
Member

I'm not really fond of harming build stability to jump back towards a snapshot to mitigate an issue in a 3rd party library which has nothing to do with us which have already mitigated the issue in their own snapshots

the annotation processor group ID also looks look wrong, but I'm not really in a place of reading up on Graal/log4js stuff to figure this out. Ideally, we'd just disable their graal VM metadata generation if viable as we don't even support native image, so, it shouldn't even matter.

@kangarko
Copy link
Author

kangarko commented Dec 7, 2024

@electronicboy Makes sense. So we're going to wait until the next log4j stable?

@kashike kashike closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since build 447 unable to use nashorn-core
4 participants