Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire Statistics Output Table Spec #55

Open
jdduh opened this issue Oct 10, 2024 · 8 comments
Open

Fire Statistics Output Table Spec #55

jdduh opened this issue Oct 10, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@jdduh
Copy link
Collaborator

jdduh commented Oct 10, 2024

It turns out FGDB featureclass's attribute table won't allow field names that begin with a number. Please move the year numbers behind alphabetical characters. This modification will greatly improve the subsequent workflow to merge the tabular data with the geometry.

Just want to confirm the coding rule for missing data, zeros, and error codes in the output tables .

Blank: missing data
Zero: value of zero (data are available but with zeros or no burns)
-1: Errors?

@jdduh jdduh added the enhancement New feature or request label Oct 10, 2024
@lbross
Copy link
Collaborator

lbross commented Oct 17, 2024

Link to corrected design spec.

@lbross
Copy link
Collaborator

lbross commented Oct 17, 2024

The coding rule for missing data, zeros, and error codes is different for nifc and mtbs data because vector and raster data are handled differently. Nifc will always have a feature class even if it doesn't have any rows. So the queries for that will return 0 for the years that don't have any data.
Mtbs data could be missing because there was no fire data that year or because the layer couldn't be clipped because there wasn't an imageservice for that year. The code looks at the collection of clipped files in the file .gdb rather than what is available on the server. For years that have no mtbs data missing data is represented as null because we just know it is missing, but not why.
The values for both always start as a -1 which means if any glitches prevent the process from completing, it will return a -1 error code.

@lbross
Copy link
Collaborator

lbross commented Oct 17, 2024

Attached is sample of updated file. Please let me know if I got it right.
2019_annual_statistics.csv

@jdduh
Copy link
Collaborator Author

jdduh commented Oct 17, 2024

Sorry, I just commented on the column naming convention. Given that the field names might get truncated (e.g., when converting the table to a shapefile table), I prefer to keep the year information upfront. The current system I use is YY19_newfireno, for example. I know the output table headings can be different from what's in the attribute table of a featureclass, but I prefer that we use the same field names.

@lbross
Copy link
Collaborator

lbross commented Oct 17, 2024

So the formula is YY + Last 2 digits of year + statistic description example: YY22_newfireno where the year is 2022. Is there any concern about representing the first two digits. Our current dataset still reaches back to 1995.

lbross added a commit that referenced this issue Oct 22, 2024
…still not right; issue #53: Rename batch_tool_settings to bagis_settings; issue #45: Calculate median elevation using station_name field instead of aoiname
@jdduh
Copy link
Collaborator Author

jdduh commented Oct 22, 2024

Let's keep just the 2 digits year. If the tool is still being used in 2095, then I would be very happy! Besides, we only allow the the clipping of the most recent 30 years of data.

@lbross
Copy link
Collaborator

lbross commented Oct 28, 2024

Attached a sample of an updated file. Please review. The selected end year for annual time period is not working in the version you have, but I fixed it.
1998_annual_statistics.csv

lbross added a commit that referenced this issue Oct 28, 2024
…nt selective end date for annual processing
@lbross
Copy link
Collaborator

lbross commented Dec 30, 2024

Always recalculate the area of the AOI. Store in session just in case. Remove aoishparea and aoishpunits from Constants class and all references. If the linear unit of the projection is not meters, write an error to the log that all statistics dependent on the aoi area may be incorrect due to projection mismatch. This is for mtbs and nifc statistics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants