-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basin Analysis Report - Summary Page #21
Comments
Add the follow text to the summary page behind the 4th line indicating the export date. For more information see the Basin Analysis Reports Users Manual at https://nwcc-nrcs.hub.arcgis.com/documents/basin-analysis-reports-users-manual |
…ix bug with data source listing where sites layers were listed twice
I would have bet money that the buffer distance was already on the title page. It was in the requirements but somehow initially missed. The infrastructure was there though and this is now done, along with the requested text. |
The Arkansas R at Salida report's summary page shows that "SNOTEL Sites: within basin – 2, within a 100 Meters buffer distance outside basin – 1". Can you verify that 100 meters is the correct buffer distance? I thought the buffer distance could be longer. |
The default buffer distance for clipping the sites layers to the AOI is 100 Meters. This is easy to change if you want too. Let me know. The desired buffer distance is being passed correctly through the code and is being stored correctly in the sites metadata. HOWEVER ... the function that clips the sites starts with the buffered AOI and then adds the desired buffer on top of that which is incorrect. I will fix this in the next release. I used the measure tool and could tell that the actual buffer was longer than what BAGIS-PRO thought it was using. |
|
See this document (https://docs.google.com/document/d/11k7kbv6pxP164z3W24vJUGsnlPoLqSJM/edit?usp=sharing&ouid=114144681831151941835&rtpof=true&sd=true) for the updates on the summary page and the data sources page. Hopefully the data sources information fits on one page. |
Can you tell me why the urls are highlighted by magenta in the data sources page? I know that Land Ownership layer url has just changed. I did that yesterday. But the roads layer looks to be the same. |
We have a new source data service for the land ownership layer and will have a new FS roads service. These URLs need to be updated. |
I have updated the land ownership layer per your request from late last week. It sounds like there is a separate update coming for roads. |
The new roads layer is published. https://services.arcgis.com/SXbDpmb7xQkk44JV/arcgis/rest/services/USFS_FSTopo_Transport_LN/FeatureServer |
…tasources page. Includes new field for data source headers. Add potential site location criteria to title page.
I posted a new version of the 06228000_WY_USGS Watershed Report to the NWCC report. Updates include
|
The legend looks good. Here are some issues that I spotted in the report.
|
The summary page was harder to fix that it should have been. I think there is a bug in the open source library we're using to convert html to pdf. The list seems to throw it off. I came up with a workaround. The buffer distance is actually stored in the buffered feature class and yes, we pull it from there. This way if the batch parameter file changes after the layer is created, we still have the correct distance. |
descriptions for some of the data sources are listed below. This is related to the information in this file: https://ebagis.geog.pdx.edu/api/rest/desktop/settings/bagis-pro/ New entry - please add this to the data sources page in the report. This entry also has a short description. Entries with short descriptions: This is related to the data sources page and the "shortDescription" information |
See the pdf for specific edits. |
Do you want to add the short descriptions to the data sources page? I am concerned that adding the DEM data source along with (potentially) the 2 new sites data sources is going to push this onto 2 pages. |
No need to include shortDescription in the data sources. Please keep the summary page and the data sources page on one page each. I will provide the edits on other pages that use the shortDescriptions. |
Is it okay to have the short description apply only going forward? I ask because the data source information is copied to an .xml file in the AOI when the layers are clipped. I pull the information for the Data Sources page from this local file. Any layers clipped prior to this enhancement won't have the short description in their xml. There are things I could do to get the information from the server retroactively, but it is extra processing if its not necessary. |
That would be OK to not have the shortDescription in previously process AOIs. We don't have an official release of the tool yet. |
Please review the title and data sources page for the D:\AOIs\2020_NWCC_Basin_Analysis_AOIs\Snake_River\HUC1706\Imnaha_R_at_Imnaha_11272010\13292000_OR_USGS_Watershed-Report.pdf on CS3 to ensure that I picked up all of your edits. |
One more edit (in bold) on the SNODAS SWE metadata, basically indicating the year range of the SWE source data. I will provide a table with maps that need the shortDescription updates. { |
I am tempted to create 3 shortDescriptions for the PRISM precip data for monthly/quarterly/annual respectively. Let me know if there is any concern. I will confirm with my final edits on the report. { |
Unfortunately I can't think of an efficient way to support 3 separate short descriptions for the PRISM precip data with the currently planned infrastructure. The short description is saved to the AOI analysis.xml file as part of the data source entry when the Prism layers are clipped and we only have a single entry for all the layers. We could add the alternative short descriptions to the configuration file on the server and read it from there, but that will update as the years on the precipitation data are rolled forward, so it will probably get out of sync with what was actually clipped. One thing that might work is to add the starting and ending prism years to the analysis.xml as separate data fields. Then I can compose the short description string on the fly, plugging in the years, for the other maps. Not as straightforward as the original design, but doable. |
Can we add anther attribute to the PRISM and call it, shortDescriptionMonthly? We can reserve the shortDescription for annual precipitation. { |
We can try your suggestion. I'm not 100% sure how it will work to have a property that only exists in one record. I am using dynamic data structures. But we can try it. I am going to change the name to make it more generic though in case we need to do something similar with another data source down the road. Perhaps shortDescription2? |
Sounds good. |
…egends plus special handling for critical precip zones; issue #8: Updates to critical precip table
…ne maps if not present; Fix export of Critical precip chart
We have a new PRISM dataset. Please update the description (by adding ", Version M4, released in December 2022" behind 1991-2020. The new dataset overrides the existing 1991-2020 imageservices on the server. { |
Both of 2 preceding items are done. Note that the updated description will only be reflected in PRISM layers clipped from here forward. Also, I decided not to implement the "shortDescriptionMonthly" parameter. I use some string replacement in the application to replace annual with monthly where appropriate. Finally ... I noticed in the desktop_settings.yaml file that the entry for BAGIS V3 in that file is still pointed to http://bagis.geog.pdx.edu/arcgis/services/BAGIS_PRISM_1981_2010. Do we want to update that to http://bagis.geog.pdx.edu/arcgis/services/BAGIS_PRISM_1991_2020/? |
Sounds good with the plan to keep just the shortDescription. Yes, please set the default PRISM of BAGIS V3 to the 1991_2020 version. |
…, Add total number of sites to title page; issue #23: Reduce font size for site labels from 14 to 10 point; Ensure there is a"." (period) at the end of the sentence on the lower-right corner of every map; Update textbox for winter precip map
Updated description for the public land ownership layer. The information is updated on the server definition file. { |
Thanks for letting me know. I have updated the desktop_settings.yaml in GitHub and confirmed that the new description appears properly on the data sources page for an AOI where the ownership layer was clipped today. |
Thanks! Please update the desktop_settings.yaml for BAGIS V3 so that the PRISM source points to http://bagis.geog.pdx.edu/arcgis/services/BAGIS_PRISM_1991_2020/. |
I did this a couple of weeks ago but you won't see it in BAGIS v3 unless you update to the default settings. I think there is a button for this. |
Thanks for updating the PRISM data source. I have been using BAGIS V3 without having PRISM data clipped to the AOIs. The clipping will happen in the BAGIS Pro batch tool. We will need to update the data sources when running the batch tool on Alaskan AOIs (see #40). |
New data source metadata for fire layers. See #49 and #50. { The information for MTBS needs further verification depending on the use of USDA WMS or PSU ArcGIS Imageservice. { |
We will need a separate summary page for the fire reports. Please don't include the original Basin Report data sources that are not used in the fire reports for now. We might need to have a merged document in future projects. |
I just checked the algorithm that generates the Basin Report data sources on the title page. We provide a list of the data sources that can appear on this page (if used). If the fire data sources aren't on this list (and they currently are not), they won't be on the title page. I'm going to close this issue again. We can create a new issue if we need to modify the main title page for the fire data. EDIT: I just added/updated the data source metadata on the server. I simplified the layer types. These values are used by the application to look-up the layer information and aren't exposed to the end user. I try to keep them simple without special characters. They are: Fire History, Fire Current, Fire Burn Severity. It's no problem to update the MTBS url when it is finalized. |
SNOTEL Sites: within basin – 2, outside basin – 0 (See SNOTEL SITES REPRESENTATION map)
Snow Courses: within basin – 0, outside basin – 2 (See SNOW COURSE SITES REPRESENTATION map)
Report the buffer distance that are used to clip the SNOTEL and Snow Courses layer. Is this a customizable value for the batch process? The summary would be something like:
SNOTEL Sites: within basin – 2, within a 5 miles buffer distance outside basin – 0 (See SNOTEL SITES REPRESENTATION map)
Snow Courses: within basin – 0, within a 5 miles buffer distance outside basin – 2 (See SNOW COURSE SITES REPRESENTATION map)
The text was updated successfully, but these errors were encountered: