Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Call mixpanel from background #288

Closed
tombeckenham opened this issue Dec 13, 2024 · 0 comments
Closed

[FEATURE] Call mixpanel from background #288

tombeckenham opened this issue Dec 13, 2024 · 0 comments
Assignees

Comments

@tombeckenham
Copy link
Collaborator

Issue to be solved

We chose to send the event to mixpanel by messaging the UI from the background script. The UI then sends the track event to mixpanel.

There are two problems with that:

  1. If the window is closed, then no event is sent. e.g. on_ramp_clicked never gets sent as the window is closed the second the user clicks on Moonpay
  2. If the window is open multiple times, then multiple events get sent for the same thing - e.g. if the user is imporing a wallet, then opens the popup to do something

That's on top of the user being able to block it using ad block of any sort

Suggest A Solution

We can use the Ingestion APIs instead of the SDKs https://developer.mixpanel.com/reference/ingestion-api

There is also some discussion of workaround as the sdks can't be used in MV3 extensions:
mixpanel/mixpanel-js#304
mixpanel/mixpanel-js#438
https://gist.github.com/doc-han/6c998058744eebafc43c132bdc28bd00

@tombeckenham tombeckenham self-assigned this Dec 13, 2024
@tombeckenham tombeckenham moved this to In Progress in Flow Wallet Dec 13, 2024
tombeckenham added a commit that referenced this issue Dec 16, 2024
@tombeckenham tombeckenham moved this from In Progress to Code Review in Flow Wallet Dec 16, 2024
tombeckenham added a commit that referenced this issue Dec 16, 2024
@tombeckenham tombeckenham moved this from Code Review to In QA in Flow Wallet Dec 17, 2024
@Peppermint1020 Peppermint1020 moved this from In QA to Done in Flow Wallet Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant