Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Test error: Error during attestation validation: Error: Invalid signature v value #606

Open
cuongdo opened this issue Oct 8, 2018 · 1 comment

Comments

@cuongdo
Copy link
Contributor

cuongdo commented Oct 8, 2018

When executing npm run test:js, I see this error scroll by:

Error during attestation validation: Error: Invalid signature v value
    at exports.ecrecover (/home/travis/build/OriginProtocol/origin-js/node_modules/ethereumjs-util/dist/index.js:403:11)
    at V00_UsersAdapter._callee8$ (/home/travis/build/OriginProtocol/origin-js/src/contractInterface/users/v00_adapter.js:206:25)
    at tryCatch (/home/travis/build/OriginProtocol/origin-js/node_modules/regenerator-runtime/runtime.js:65:40)
    at Generator.invoke [as _invoke] (/home/travis/build/OriginProtocol/origin-js/node_modules/regenerator-runtime/runtime.js:303:22)
    at Generator.prototype.(anonymous function) [as next] (/home/travis/build/OriginProtocol/origin-js/node_modules/regenerator-runtime/runtime.js:117:21)
    at step (/home/travis/build/OriginProtocol/origin-js/src/contractInterface/users/v00_adapter.js:21:191)
    at /home/travis/build/OriginProtocol/origin-js/src/contractInterface/users/v00_adapter.js:21:361
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

Tests seem to pass though. I suspect we're not awaiting an async function somewhere in the user resource tests, so mocha is not detecting the error. This happens in CI too. For example:

https://travis-ci.org/OriginProtocol/origin-js/jobs/437663625#L1617

@cuongdo
Copy link
Contributor Author

cuongdo commented Oct 8, 2018

Assigning to @tyleryasaka, because he's already looking at the identity contracts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants