Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OSI pip install with pypi #69

Open
ClemensLinnhoff opened this issue Apr 4, 2024 · 1 comment
Open

Use OSI pip install with pypi #69

ClemensLinnhoff opened this issue Apr 4, 2024 · 1 comment
Assignees
Labels
feature request Proposals which enhance the interface or add additional features.

Comments

@ClemensLinnhoff
Copy link
Contributor

Describe the feature

Currently OSI is a submodules, while parts of it (OSITracy.py) are not even used (see #55)
There is a current development in OSI to make it a PYPI package: OpenSimulationInterface/open-simulation-interface#800

Describe the solution you would like

Make the OSI PYPI package a dependency, and remove the submodule.
Then use the osi_tracy.py as an import from that package (solving #55).

Describe alternatives you have considered

Using OSI as a submodule would also work, but just making OSI a requirement will be a lot easier

Describe the backwards compatibility

This will entail and OSI update to upcoming version 3.7. But since OSI itself it backwards compatible, this should not impact backwards compatibility of osi-validation

@ClemensLinnhoff ClemensLinnhoff added the feature request Proposals which enhance the interface or add additional features. label Apr 4, 2024
@ClemensLinnhoff ClemensLinnhoff self-assigned this Apr 4, 2024
@ClemensLinnhoff
Copy link
Contributor Author

Give an alternative build instruction for development with branches of OSI, that are not available as as PYPI package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Proposals which enhance the interface or add additional features.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant