Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify rules in YML-File #28

Open
rruisong opened this issue Aug 26, 2020 · 2 comments
Open

Specify rules in YML-File #28

rruisong opened this issue Aug 26, 2020 · 2 comments
Labels
bug Problems in the build system, build scripts, etc or faults in the interface.

Comments

@rruisong
Copy link

Describe the bug

We can define the rules for one type of data (i.e. osi-message) only once in yml-file. For example: If we only want to check 'SensorView.InterfaceVersion', the 'SensorView.GroundTruth.InterfaceVersion' will also be automatically checked. Because we can only define the rules for the type of data 'InterfaceVersion'

Describe how to reproduce the bug

Steps to reproduce the behavior:

  1. Get the file '20200820_example_versionTest.osi' and 'osi_version.yml' from zip-file attached.
  2. Move the file '20200820_example_versionTest.osi' to folder 'data'
  3. Move the file 'osi_version.yml' to folder 'requirements-osi-3'
  4. Run 'osivalidator -r -requirements-osi-3 .\data\20200820_example_versionTest.osi'
  5. See output

Describe the expected behavior

We supposed to check if the major version of 'SensorView' is greater than 3 and didn't mean to check the major version of 'SensorView.GroundTruth'. We would define the two different kinds of version separately.

Show some screenshots

image

Describe the OS you are using

  • OS: Windows 10
  • Language: Python
  • Version 3.7

Additional context

Please get the osi- and yml-file from this zip-file.
ForOsiIssue.zip

@rruisong rruisong added the bug Problems in the build system, build scripts, etc or faults in the interface. label Aug 26, 2020
@vkresch
Copy link
Contributor

vkresch commented Aug 27, 2020

That's a good point! This should "normally" be solved by keeping the osi_version.yml as is and add rules to osi_sensorview.yml like this:

SensorView:
  version:
    version_major:
      - is_greater_than: 3

which does not generate an output at all hence there is a bug somewhere in the tree parser implementation which needs to be solved. I will take a more detailed look when I have more time. Thanks for the report!

@rruisong
Copy link
Author

Yes, I tried this "normal" way to add the rules as well. As you mentioned, it doesn't generate the corresponding output. Thank you for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problems in the build system, build scripts, etc or faults in the interface.
Projects
None yet
Development

No branches or pull requests

2 participants