Use of binary_to_existing_atom

[martinsumner]

See basho/riak_core#950

This is an issue where binary_to_existing_atom/2 is used, but the expected existing atom may or may not be present depending on the order which modules have loaded.

There are other places where the function is used:

https://github.com/OpenRiak/riak_core/blob/1b01278e762b835c0777d5c7319fe7b22186560d/src/riak_core_console.erl#L1212

https://github.com/OpenRiak/riak_core/blob/1b01278e762b835c0777d5c7319fe7b22186560d/src/riak_core_console.erl#L1225

riak_kv/src/riak_kv_util.erl

Line 189 in 9cb8d00

binary_to_existing_atom(Val, utf8)

riak_kv/src/riak_kv_util.erl

Line 202 in 9cb8d00

ExistingAtom = binary_to_existing_atom(RW, utf8),

riak_kv/src/riak_kv_pb_object.erl

Line 189 in 9cb8d00

riak_client:fetch(binary_to_existing_atom(QueueName, utf8), C)

riak_kv/src/riak_kv_pb_object.erl

Line 243 in 9cb8d00

QueueName = binary_to_existing_atom(QueueNameBin, utf8),

riak_kv/src/riak_kv_crdt.erl

Line 497 in 9cb8d00

Mod = binary_to_existing_atom(Type, latin1),

riak_kv/src/riak_kv_crdt_json.erl

Line 156 in 9cb8d00

{Name, binary_to_existing_atom(BinType, utf8)};

Is the function used safely in all these places?

[martinsumner]

riak_kv/src/riak_kv_util.erl

Line 189 in 9cb8d00

binary_to_existing_atom(Val, utf8)

Appears to be an unused export, so is only used to expand the sync_on_write. This is expanding a default bucket property - so should already be an atom?