Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makefile for "afutests": afp and mcp #24

Open
luyong6 opened this issue Dec 29, 2018 · 3 comments
Open

Add makefile for "afutests": afp and mcp #24

luyong6 opened this issue Dec 29, 2018 · 3 comments

Comments

@luyong6
Copy link

luyong6 commented Dec 29, 2018

Is the folder "afutests" for a sanity check? If so, please add Makefile for that.

@luyong6
Copy link
Author

luyong6 commented Dec 29, 2018

And the Readme of AFP usage is not in a good shape.
@deece I don't know if I should write to you but please convey it to the right person. Thank you!

@deece
Copy link
Contributor

deece commented Jan 2, 2019

The afutests dir contains exercisers for some of the reference AFU images, they are included in LibOCXL so that they can be versioned alongside the library and used as an example if needed (although they are much more verbose than desired as sample code).

They are automatically built by the top level Makefile.

@luyong Do you have specific things that can be improved in the AFP documentation?

@philippe56 Anything to add?

@luyong6
Copy link
Author

luyong6 commented Jan 2, 2019

Oh I just found that the output binary executables were put in folder "afuobj"
Would you add one line in README? That's simple but friendly.

And the help message of AFP currently is crowded as below and no one would read.
I suggest just to say "please run ./ocxl_afp3 -h" to get the options before running it.

Usage: ocxl_afp3 [ options ] --tags_ld Number of tags for loads. Default=0 --tags_st Number of tags for stores. Default=0 0 - 0 tags (disabled) 1 - 1 tag 2 - 2 tags 3 - 4 tags 4 - 16 tags 5 - 64 tags 6 - 256 tags 7 - 512 tags --size_ld Data size, in Bytes, for loads. Supported values: 64, 128, 256. Default=128 --size_st Data size, in Bytes, for stores. Supported values: 64, 128, 256. Default=128 --npu_ld Use rd_wnitc.n for loads. Default is rd_wnitc --npu_st Use dma_w.n for stores. Default is dma_w --num Number of times to check perf counts. Default is 3 --wait Amount of seconds to wait between perf count reads. Default is 2 --prefetch Initialize buffer memory --offsetmask Determines how much of buffer to use. Default 512kB. Valid Range: 4K-512M. Format: NumberLetter, e.g. 4K, 512K, 1M, 512M --timeout Default=1 seconds --verbose Verbose output --help Print this message

philippe56 added a commit to philippe56/libocxl that referenced this issue Jan 15, 2019
This fixes issue OpenCAPI#24.

Signed-off-by: Philippe Bergheaud <[email protected]>
deece pushed a commit that referenced this issue Jan 15, 2019
This fixes issue #24.

Signed-off-by: Philippe Bergheaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants