Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a caching strategy for repo_to_installation_id_mapping #12

Open
Cadair opened this issue Jul 24, 2018 · 2 comments
Open

Consider a caching strategy for repo_to_installation_id_mapping #12

Cadair opened this issue Jul 24, 2018 · 2 comments

Comments

@Cadair
Copy link
Member

Cadair commented Jul 24, 2018

That function uses a lot of GitHub API calls and takes a long time, it also probably doesnt change that often.

We should cache it and then either blow the cache away on a miss, or just try and extend the cache on a miss. The only thing this plan doesnt handle is how to remove an app from the cache if it is uninstalled on GitHub.

@Cadair
Copy link
Member Author

Cadair commented Jul 24, 2018

As in #14 this https://pypi.org/project/expiringdict/#description might be useful here.

@astrofrog
Copy link
Collaborator

This is a WIP by @Cadair here: https://github.com/astrofrog/baldrick/pull/17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants