From b7918b887abc2d01a2360280f16cdaa3405b9b7a Mon Sep 17 00:00:00 2001 From: Kumar Gala Date: Fri, 13 Apr 2018 10:54:49 -0500 Subject: [PATCH] virtqueue: Remove TODO comments We can open issues to track any todo items. Signed-off-by: Kumar Gala --- lib/include/openamp/virtqueue.h | 3 --- lib/virtio/virtqueue.c | 9 --------- 2 files changed, 12 deletions(-) diff --git a/lib/include/openamp/virtqueue.h b/lib/include/openamp/virtqueue.h index b7fc67a34..43b2cd734 100644 --- a/lib/include/openamp/virtqueue.h +++ b/lib/include/openamp/virtqueue.h @@ -64,9 +64,6 @@ typedef enum { } vq_postpone_t; struct virtqueue { - //TODO: Need to define proper structure for - // virtio device with RPmsg and paravirtualization. - struct virtio_device *vq_dev; char vq_name[VIRTQUEUE_MAX_NAME_SZ]; uint16_t vq_queue_index; diff --git a/lib/virtio/virtqueue.c b/lib/virtio/virtqueue.c index 629cdf959..ef608e6f3 100644 --- a/lib/virtio/virtqueue.c +++ b/lib/virtio/virtqueue.c @@ -57,8 +57,6 @@ int virtqueue_create(struct virtio_device *virt_dev, unsigned short id, VQ_PARAM_CHK(ring->num_descs & (ring->num_descs - 1), status, ERROR_VRING_ALIGN); - //TODO : Error check for indirect buffer addition - if (status == VQUEUE_SUCCESS) { vq_size = sizeof(struct virtqueue) @@ -89,9 +87,6 @@ int virtqueue_create(struct virtio_device *virt_dev, unsigned short id, virtqueue_disable_cb(vq); *v_queue = vq; - - //TODO : Need to add cleanup in case of error used with the indirect buffer addition - //TODO: do we need to save the new queue in db based on its id } return (status); @@ -126,14 +121,10 @@ int virtqueue_add_buffer(struct virtqueue *vq, struct metal_sg *sg, VQ_PARAM_CHK(needed < 1, status, ERROR_VQUEUE_INVLD_PARAM); VQ_PARAM_CHK(vq->vq_free_cnt == 0, status, ERROR_VRING_FULL); - //TODO: Add parameters validation for indirect buffer addition - VQUEUE_BUSY(vq); if (status == VQUEUE_SUCCESS) { - //TODO : Indirect buffer addition support - VQASSERT(vq, cookie != NULL, "enqueuing with no cookie"); head_idx = vq->vq_desc_head_idx;