-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nothing happens #13
Comments
Hi! Can you check if the plans are being generated normally? From the screenshot it looks like it but just to double check. Also what is your computing information? |
Weird, seems like interaction is bugged. Just to double check, the config file is not modified right? |
Thank you very much for your reply. Does the configuration file refer to the file gpt4_base_config.yaml? I did not make any changes to this file. |
Hi i am having this same issue It seems that the (my version of) env.step will only intake low-level actions. Not Navigation toaster, but go to toaster 1 @LightCheat |
I think the code is missing the step where it converts high level plan (high_pddl) to low level actions (low_actions) |
Hi, I found that there is a bug where the updated OpenAI package has a conflict with grounding the objects (for interaction actions). We’re working actively to fix this since but it needs some overhaul. In the meantime, high level plan generation works totally fine. Sorry and please be patience! |
HI @chanhee-luke , i think the OpenAI version problem is ok, right? I think the high level plan actions are fine, i'm just having trouble finding where they convert to low level ones |
Sorry idk if we can call them "low_level". I just mean mapping "Navigation" to "go to", maybe this old vocabulary was used in alfworld==0.2.2? I'm using alfworld==0.3.3 right now, the newest one so maybe that vocab doesn't work anymore? EDIT: I think i found it. The parse_command() in alfworld/alfworld/agents/controller/base.py in between version 0.2 and 0.3. It's causing more conflict, i'll try to see what i can do |
Hi, you can try replacing the file alfworld/alfworld/agents/base.py with the same file in the same path in this repository. The author has modified this file and redefined go to as navigation. |
@LightCheat do u mean alfworld/alfworld/agents/controller/base.py? I think we gotta input the object index as well |
I haven't solved this problem, you can take a look at the screenshot of my above answer. I tried to add a number after the subtasks, and some of them can be executed normally. But I have no way to make any further modifications. |
If we can have the num_id of the objects that are visible: |
Yes, it can be continued through this method. But I believe that if there are multiple objectives, the order may not be easy to grasp, and it may also lead to errors in other parts of the author's code, so I gave up on making subsequent modifications. |
Wait, I assume that in LLM-Planner, it just knows that an object like fridge exists, but not know which fridge (1 or 2) it's going to, right? Cuz from the issues and code I'm reading in alfworld's repo alfworld/alfworld#16, they generate object index sequentially on the fly. Can you confirm that the robot doesn't go to the objects it sees, but just go to a random object? @chanhee-luke correct me if i'm wrong, pls |
Hi @BatmanofZuhandArrgh, for LLM-Planner, the priority of the object selection is 1) objects that are visible, 2) objects that exist in the environment. Usually there aren't many cases of multiple instances of same object type (e.g. single fridge) so it has minor impact to the overall success rate. The main translation from the generated high level plan to Ai2Thor compatible plans happen in
We are currently working on replacing the ALFWorld backbone since it's not easily compatible with other datasets/simulators and MLLMs so in the meantime I recommend using this codebase (https://github.com/lbaa2022/LLMTaskPlanning). Please look out for the revamped codebase soon. |
Hi @chanhee-luke , thank you for your reply. My problem here is that from |
First of all, the ALFRED task is designed so that usually you can interact with any object of the same kind to complete the task. Which means that if you need to slice an apple, you can slice any apple in the room to be counted as successful. The ALFWorld simulator keeps track of visible objects by default so the code is accessing that visible object information from the simulator. If there are multiple visible objects of the same type (e.g. multiple apples) it randomly chooses one. LLM-Planner does not output index and the code doesn't use index at all. |
Okie thank u so much for the live tech support lol @chanhee-luke |
So, does this means this codebase cannot be reproduced without bug? I mean the Nothing happen is because of the bugs or the capacity of the llm-planner? |
Hi @lxsy-xcy . No you can still generate high level plans and compare them with the results on the paper. We have all the prompts used in the codebase. Our work aims to show the potential of the LLM in high level planning. Thanks for the interest! |
thanks! But does this codebase can have a accurate success rate of the high level planning? I got a lot "0", I don't know if that means the llm-planner cannot solve this question or just because of the ALFWORLD part have some bugs? |
No since high-level planning SR != SR. There could be issues of the low-level planner that is independent of the high-level planning. ALFWORLD part do seem to have bugs. We are trying to decouple it from the LLM-Planner so people can use it independently of any low-level planner. |
Okie! Thank you for your reply |
Hi, when I execute your code, I will prompt for nothing happens. I would like to ask if this question is normal. I have been executing it for about an hour and it has always been prompted with nothing happens. I am using Alfworld version 0.3.3, but the same issue occurs when I downgrade to 0.2.2. I hope to receive your answer, thanks
In addition, there will be a warning prompt, and I am not sure if this warning will affect the normal execution of the program.
The text was updated successfully, but these errors were encountered: