Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transect selection functionality is not complete #139

Open
Tracked by #141
leewujung opened this issue Dec 5, 2023 · 0 comments
Open
Tracked by #141

Transect selection functionality is not complete #139

leewujung opened this issue Dec 5, 2023 · 0 comments
Labels
bug_in_python Something in the Python implementation does not match what's in Matlab
Milestone
bootstrapping

Comments

@leewujung
Copy link
Member

leewujung commented Dec 5, 2023 •
edited
Loading

The option selected_transects in set_class_variables is not functional at all, because the condition below will never be True seems functional but the code is really messy: all_transects_selected is used twice but that does not seem necessary:
https://github.com/uw-echospace/EchoPro/blob/2c832292cb9cbae0b5bfd07c0b1ef328043d94c2/EchoPro/computation/transect_results.py#L923-L932

There are also multiple places in the code that has TODO related to transect selection:
https://github.com/uw-echospace/EchoPro/blob/2c832292cb9cbae0b5bfd07c0b1ef328043d94c2/EchoPro/computation/transect_results.py#L250-L255
and
https://github.com/uw-echospace/EchoPro/blob/2c832292cb9cbae0b5bfd07c0b1ef328043d94c2/EchoPro/computation/transect_results.py#L586-L591

Notebook docs/transect_selection_workflow.ipynb can be used to trace down what still needs to be implemented to allow transect selection.
@leewujung leewujung added the bug_in_python Something in the Python implementation does not match what's in Matlab label Dec 5, 2023
@leewujung leewujung mentioned this issue Dec 5, 2023
Closed
3 tasks
@leewujung leewujung changed the title selected_transects in set_class_variables is not functional Transect section function is not complete Dec 5, 2023
@leewujung leewujung changed the title Transect section function is not complete Transect selection functionality is not complete Dec 5, 2023
@emiliom emiliom mentioned this issue Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug_in_python Something in the Python implementation does not match what's in Matlab
Projects
Echopop
Status: No status
Milestone
bootstrapping
Development

No branches or pull requests
1 participant
@leewujung