Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlights to existing file #243

Open
kelszo opened this issue Dec 4, 2023 · 1 comment
Open

Add highlights to existing file #243

kelszo opened this issue Dec 4, 2023 · 1 comment

Comments

@kelszo
Copy link

kelszo commented Dec 4, 2023

It would be nice to be able to sync highlights to an existing file (such as notes created by Book Search). Initially, I considered using the ISBNs from the SQLite database and matching them with an ISBN field in the frontmatter for this purpose. However, the complexity arises due to the nature of ISBNs. Since a single book may have multiple ISBNs, varying with the publisher and edition, this method might result in incorrect identification of many books. A more reliable, albeit slightly unorthodox, approach could be to perform string matching between the book's title/author fields between the SQLite database and frontmatter.

Should this feature seem like a viable addition to the code base, I am happy to contribute by submitting a PR.

@OGKevin
Copy link
Owner

OGKevin commented Dec 5, 2023

hmm, I think this feature can use some of the work that has been done in #107

I'll poke the author one more time if they have any plans on finishing it, if not, i'll pick up where they've left off and finish it.
Then we can see if the markers introduced in this file can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants