Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper form widget extension instead of overriding the fileupload partial #84

Open
alxy opened this issue Dec 11, 2021 · 1 comment

Comments

@alxy
Copy link

alxy commented Dec 11, 2021

As I can see, currently the entire fileupload form widget partial is being overridden by this plugin. This makes it very hard for other plugins to also add additional functionality to the fileupload widget.

Since some time now the title and description fields are actually a form widget which can be extended using the usual October extension methods. The idea would be to rather use this mechanism to extend the form with the required hidden fields. This would enable other plugins to also safely extend the form without colliding with this plugin.

@tobias-kuendig
Copy link
Member

Thank you very much for this feedback @alxy! We will take a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants