Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to Tailwind 1.7 #8

Open
chrisvidal opened this issue Oct 5, 2020 · 2 comments
Open

Conversion to Tailwind 1.7 #8

chrisvidal opened this issue Oct 5, 2020 · 2 comments

Comments

@chrisvidal
Copy link

chrisvidal commented Oct 5, 2020

I've made a fork of the theme and convert it to Tailwind 1.7, available code here https://github.com/Voilaah/oc-mall-theme

JS and SCSS compilation is ok, however, at this stage I didn't yet test the theme itself.

@tobias-kuendig
Copy link
Member

Thank you @chrisvidal for your work. I will certainly check out your fork. But I'm not sure yet about how to proceed with this as this might introduce breaking changes.

On the other hand, themes are usually not updated often, and for new installations a newer Tailwind version does not hurt.

@chrisvidal
Copy link
Author

I needed to upgrade to a more recent TW version for a client project anyway.
It is feeling quite necessary for this Mall theme, TW has lots of new interesting stuff.

Yes, it is slightly breaking some of the existing Mall css, but not so much actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants