Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling configuration files #8

Open
musjj opened this issue Nov 19, 2020 · 2 comments
Open

Handling configuration files #8

musjj opened this issue Nov 19, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@musjj
Copy link

musjj commented Nov 19, 2020

mplug currently supports installing .conf template files from repos. But the problem comes when it's time to update your plugins.
It seems that currently, the update process mostly consists of git pulling the various plugin repos we have. But what if we have made local changes to those .conf files and there are new commits on those .conf files upstream? I'm not familiar with git, but I assume this will create a conflict.
What do you think?

@Nudin
Copy link
Owner

Nudin commented Jan 23, 2021

Yes, the updates are done by pulling the current state via git. If only the local version or only the upstream version of the file has changed this will work fine. If both, the user and the plugin author change the same file git will try to merge both versions, if however the same line was changed in both versions there will be a conflict.
This is not yet handled by mplug, the tool should probably ask the user about what to do.

@Nudin Nudin added the enhancement New feature or request label Jan 23, 2021
@vnbubba
Copy link

vnbubba commented Sep 26, 2021

Hello, I tried to uninstalled my plugin but my terminal show that:
mplug uninstall mpv-autosub
No environment variable found, guessing /home/hoang/.mpv as mpv config folder.
Not installed: mpv-autosub
How should i fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants