Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] CV fails when df is not provided #800

Open
jmoralez opened this issue Oct 27, 2023 · 0 comments · May be fixed by #801
Open

[Core] CV fails when df is not provided #800

jmoralez opened this issue Oct 27, 2023 · 0 comments · May be fixed by #801
Labels
bug

Comments

@jmoralez
Copy link
Member

What happened + What you expected to happen

This line

neuralforecast/neuralforecast/core.py

Line 542 in ff1566c

fcsts_df = fcsts_df.merge(df, how="left", on=["unique_id", "ds"])

tries to merge with df, which can be None, so in that case it fails.

Originally reported here

Versions / Dependencies

1.6.4

Reproduction script

model = NeuralForecast(
                [AutoNBEATS(**model_args)],
                freq='D',
            )
model.fit(df=data, val_size=horizon)
crossvalidation_df = model.cross_validation()

Issue Severity

Low: It annoys or frustrates me.
@jmoralez jmoralez added the bug label Oct 27, 2023
@americast americast linked a pull request Oct 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Crossvalidation when dataframe is not provided americast/neuralforecast
1 participant
@jmoralez