Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: deprecate NIXTLA_ID_AS_COL or issue warning #1234

Closed
elephaint opened this issue Dec 19, 2024 · 1 comment · Fixed by #1220
Closed

Chore: deprecate NIXTLA_ID_AS_COL or issue warning #1234

elephaint opened this issue Dec 19, 2024 · 1 comment · Fixed by #1220
Assignees
Labels

Comments

@elephaint
Copy link
Contributor

What happened + What you expected to happen

We need to make NIXTLA_ID_AS_COL the default behavior or start showing deprecation messages, as the default behavior of NF is now inconsistent with the API of our other libs (SF, MF, HF).

Versions / Dependencies

1.7.7

Reproduction script

n/a

Issue Severity

Low: It annoys or frustrates me.

@elephaint elephaint added the bug label Dec 19, 2024
@elephaint elephaint self-assigned this Dec 19, 2024
@jmoralez
Copy link
Member

This is what is done in #1220

@marcopeix marcopeix linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants