Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to using the PEP 8 style guide #16

Closed
Nihilate opened this issue Aug 27, 2018 · 7 comments
Closed

Convert to using the PEP 8 style guide #16

Nihilate opened this issue Aug 27, 2018 · 7 comments

Comments

@Nihilate
Copy link
Owner

All files, functions and variables should follow the recommended Python style guide (PEP 8).

@reillysiemens
Copy link
Contributor

@Nihilate: I'm happy to take this one if you want to assign it to me. I think it'll help make the other issues in this project a little easier to tackle.

@Nihilate
Copy link
Owner Author

Nihilate commented Sep 2, 2018

Sounds good to me, go ahead :)

@reillysiemens
Copy link
Contributor

FWIW, I think that once the majority of PEP8 violations are taken care of then linting should be added as a CI step to keep the code from regressing in that regard.

@Nihilate
Copy link
Owner Author

Nihilate commented Sep 2, 2018

Definitely. I've added #53 to add a code coverage report (failing the build on low coverage might not be an option given how low it is at the moment) and #54 to add linting (with failures on regression).

@reillysiemens
Copy link
Contributor

reillysiemens commented Oct 15, 2019

Hey, @Nihilate, I did some work on this last year, but since then I've come to really enjoy using Black to just auto-format code. Would you be amenable to closing this issue in favor of resolving all style issues through auto-formatting? I'd be happy to open an issue and submit a corresponding PR if that sounds good to you.

@Nihilate
Copy link
Owner Author

Hey! Sounds reasonable to me - I've been using RuboCop at work and the auto-formatter for that has been really useful. I'll open another issue.

@Nihilate
Copy link
Owner Author

I've created a new enhancement over here: #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants