Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many core layouts force the page layout to one of the five included with the core #4

Open
ericmorand opened this issue Oct 11, 2020 · 0 comments

Comments

@ericmorand
Copy link
Member

ericmorand commented Oct 11, 2020

Violation

Many core layouts force the page layout to one of the five included with the core.

Why it is a violation

This issue prevents developers to provide custom page layouts and remove the core ones without reviewing and extending every layouts provided by the core modules. This is a violation because layouts are provided by modules and module writers can't know by advance what page layouts will be available at runtime. Magento 2 implementers are expected to remove the five default page layouts and provide their own custom ones because the chance that the design they have to implement fits in one of these five page layouts are very slim.

This is a blatant violation of the principle of Separation of Concerns: layouts don't know anything about where and how they will be used, and they must not assume anything in that regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant