Feature/223 환불 flow 교체 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 7 files 7 suites 0s ⏱️ Results for commit ab15a4b. ♻️ This comment has been updated with latest results. |
HamBP
commented
Apr 28, 2024
| @@ -130,7 +130,7 @@ fun TicketingScreen( | |||
| context = context, | |||
| amount = uiState.totalPrice, | |||
| clientKey = BuildConfig.TOSS_CLIENT_KEY, | |||
| customerKey = it.userId, | |||
| customerKey = "user-${it.userId}", | |||
There was a problem hiding this comment.
땡큐 ㅋㅋ 슈퍼준영쓰
근데 이거 포맷은 추후에 iOS 쪽이랑 더 고민해보려고 (최소한 인코딩을 한다거나 해서 규칙을 유추하기 어렵게)
mangbaam
approved these changes
Apr 30, 2024
presentation/src/main/java/com/nexters/boolti/presentation/extension/PaymentType.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/nexters/boolti/presentation/screen/refund/RefundViewModel.kt
Outdated
Show resolved
Hide resolved
| @@ -130,7 +130,7 @@ fun TicketingScreen( | |||
| context = context, | |||
| amount = uiState.totalPrice, | |||
| clientKey = BuildConfig.TOSS_CLIENT_KEY, | |||
| customerKey = it.userId, | |||
| customerKey = "user-${it.userId}", | |||
There was a problem hiding this comment.
땡큐 ㅋㅋ 슈퍼준영쓰
근데 이거 포맷은 추후에 iOS 쪽이랑 더 고민해보려고 (최소한 인코딩을 한다거나 해서 규칙을 유추하기 어렵게)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용