Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating AFNI dependencies #791

Closed
mrneont opened this issue Apr 29, 2024 · 5 comments
Closed

Updating AFNI dependencies #791

mrneont opened this issue Apr 29, 2024 · 5 comments
Assignees

Comments

@mrneont
Copy link

mrneont commented Apr 29, 2024

Howdy-

I recently checked in on the AFNI install on Neurodesk. I think there are a couple of things to update there:

  • We now use the Python modules Flask and Flask-Cors for setting up a local server to interact with afni_proc.py's QC HTML. Those don't appear to be available after ml afni.
  • We also use NiiVue as part of the same APQC HTML. We distribute this with our binaries and as part of our build scripts, which basically means building+copying in a compiled niivue_afni.umd.js file in the same location as the main AFNI binaries (i.e., where which afni points). We actually put a copy of the niivue_afni.umd.js file that we build in an openly accessible spot for ease of access, and so it could be gotten with:
     curl -O https://afni.nimh.nih.gov/pub/dist/bin/misc/niivue_afni.umd.js
    

It would be great if both of those aspects could be updated.

thanks,
pt

@stebo85
Copy link
Contributor

stebo85 commented Apr 29, 2024

Dear @mrneont,

Yes, we can make these updates. To clarify what's needed:

  1. what are the binary names for this? What is the command you would want to run after a module load to test this?
  2. niivue_afni.umd.js is already there:
afni-24.1.02:/opt/afni-latest$ find . | grep niivue
./afnipy/lib_apqc_niivue.py
./niivue_afni.umd.js

What else is needed to make this work? How can I test this?

@mrneont
Copy link
Author

mrneont commented Apr 29, 2024

Hi, @stebo85 -

Thanks for the quick reply!

  1. About Flask and Flask-Cors: these are just Python modules to load. To install these in Ubuntu, say, I would just do:

    sudo apt-get install python3-flask python3-flask-cors
    

    To test this, one would just want to see version numbers for each module detected by the system check:

      afni_system_check.py -disp_ver_pylibs flask flask_cors
    

    A deeper test of functionality would involve running afni_proc.py for a full FMRI processing run, and then opening the created QC HTML with open_apqc.py -infiles ... and seeing that the HTML buttons worked. That might be a more difficult test, but I'm happy to discuss that more if that would be useful.

  2. Huh, OK, I tried using Neurodesk from "https://www.neurodesk.org/" -> Play -> Terminal, and then I didn't see it when I module loaded afni (I apologize for copy+pasting a screenshot here, but I couldn't figure out how to copy the text from the terminal):
    Screenshot from 2024-04-29 19-49-05
    I guess I am not understanding why this is different.

thanks,
pt

@stebo85
Copy link
Contributor

stebo85 commented Apr 30, 2024

  1. Ok, I will add these and test with afni_system_check.py - currently this outputs in afni 23.3.02:
** error: unknown trailing arguments : ['-disp_ver_pylibs', 'flask', 'flask_cors']

So I guess an update to the latest AFNI version will fix that?

  1. the module system only exposes binaries on the top level. The niivue files are inside the container subdirectory:
ls /cvmfs/neurodesk.ardc.edu.au/containers/afni_24.1.02_20240409/afni_24.1.02_20240409.simg/opt/afni-latest/niivue_afni.umd.js 
/cvmfs/neurodesk.ardc.edu.au/containers/afni_24.1.02_20240409/afni_24.1.02_20240409.simg/opt/afni-latest/niivue_afni.umd.js

@mrneont
Copy link
Author

mrneont commented Apr 30, 2024

  1. Indeed, I guess the option -disp_ver_pylibs is newer than that version.

  2. Ah, I see---thanks for clarifying that.

@stebo85 stebo85 self-assigned this Aug 21, 2024
@stebo85 stebo85 transferred this issue from NeuroDesk/neurodesktop Aug 30, 2024
@stebo85
Copy link
Contributor

stebo85 commented Oct 4, 2024

This is now completed in our latest afni container with version 24.3.00
image

Thank you for flagging this with us:)

@stebo85 stebo85 closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Active to Completed in NeuroDesk Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

No branches or pull requests

2 participants