Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add interface location.broadcast_domain parameter #337

Open
wants to merge 9 commits into
base: integration/main
Choose a base branch
from
Open

[Enhancement]: Add interface location.broadcast_domain parameter #337

wants to merge 9 commits into from

Conversation

acch
Copy link

@acch acch commented Nov 20, 2024 •
edited
Loading

Adds ability to configure location.broadcast_domain parameter of IP Interfaces.

Closes #305.

Acceptance tests pass:

$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_test.go -v
=== RUN   TestAccNetworkIpInterfaceResource
--- PASS: TestAccNetworkIpInterfaceResource (10.65s)
PASS
ok      command-line-arguments  10.664s
$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_alias_test.go -v
=== RUN   TestAccNetworkIpInterfaceResourceAlias
--- PASS: TestAccNetworkIpInterfaceResourceAlias (9.21s)
PASS
ok      command-line-arguments  9.225s

Example Terraform Configurations:

resource "netapp-ontap_network_ip_interface" "with_node_port" {
  cx_profile_name = ...
  name            = ...
  svm_name        = ...

  ip = { ... }

  location = {
    home_port = "e0a-100"
    home_node = "node1"
  }
}
resource "netapp-ontap_network_ip_interface" "with_broadcast_domain" {
  cx_profile_name = ...
  name            = ...
  svm_name        = ...

  ip = { ... }

  location = {
    broadcast_domain = {
      name = "bd1"
    }
  }
}

acch added 8 commits November 20, 2024 13:07
@acch
feat: add location.broadcast_domain to IP interface data source
042f939 
Signed-off-by: Achim Christ <[email protected]>
@acch
feat: add location.broadcast_domain to IP interfaces data source
971c09b 
Signed-off-by: Achim Christ <[email protected]>
@acch
feat: make existing location attributes optional
48e9b10 
Signed-off-by: Achim Christ <[email protected]>
@acch
feat: add location.broadcast_domain to IP interfaces resource
a4a07b2 
Signed-off-by: Achim Christ <[email protected]>
@acch
feat: add examples for cluster-, and svm-scoped IP interfaces
e949a37 
Signed-off-by: Achim Christ <[email protected]>
@acch
feat: add examples for using node & port-, and broadcast domain for l…
6a5d81b 
…ocation

Signed-off-by: Achim Christ <[email protected]>
@acch
fix: add home port & node to POST request when defined, even if uncha…
39cb809 
…nged

Signed-off-by: Achim Christ <[email protected]>
@acch
feat: add acceptance tests for 'location' attribute combinations
f1d2dde 
Signed-off-by: Achim Christ <[email protected]>
@acch acch marked this pull request as ready for review November 28, 2024 15:31
@acch acch mentioned this pull request Nov 28, 2024
Open
@acch acch changed the title Add interface location.broadcast_domain parameter [Enhancement] Add interface location.broadcast_domain parameter Dec 9, 2024
@acch acch changed the title [Enhancement] Add interface location.broadcast_domain parameter [Enhancement]: Add interface location.broadcast_domain parameter Dec 9, 2024
@carchi8py carchi8py added the enhancement New feature or request label Dec 9, 2024
@carchi8py carchi8py added this to the 2.1 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carchi8py carchi8py Awaiting requested review from carchi8py carchi8py is a code owner

@chuyich chuyich Awaiting requested review from chuyich chuyich is a code owner

@suhasbshekar suhasbshekar Awaiting requested review from suhasbshekar suhasbshekar is a code owner

@wenjun666 wenjun666 Awaiting requested review from wenjun666 wenjun666 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Terraform for ONTAP Roadmap
Status: 2.1
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add interface location.broadcast_domain parameter
2 participants
@acch @carchi8py