Include file, line and mfa in basic formatter metadata #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppeerttu
force-pushed
the
fix/include-file-line-mfa-in-basic-formatter-metadata
branch
from
2365e64 to
9a2decf
Compare
AndrewDryga
reviewed
Oct 14, 2024
| assert metadata |> Map.get("file") |> to_string() =~ "logger_json/formatters/basic_test.exs" | ||
| assert metadata |> Map.get("line") |> is_integer() | ||
|
|
||
| assert metadata["mfa"] === [ |
There was a problem hiding this comment.
To make it more readable I think we need a special case for encoding this one, making it look like an anonymous function, e.g.: Elixir.LoggerJSON.Formatters.BasicTest."test logs file, line and mfa as metadata"/1. See here: https://github.com/Nebo15/logger_json/blob/master/lib/logger_json/formatters/google_cloud.ex#L237
There was a problem hiding this comment.
Indeed, good point. How about now?
There was a problem hiding this comment.
@AndrewDryga pinging just in case forgotten - please have a look whenever you have time! 🙏
ppeerttu
force-pushed
the
fix/include-file-line-mfa-in-basic-formatter-metadata
branch
from
9a2decf to
edbcad7
Compare
|
Would love to see this merged in - anything I can do to help move it along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include file, line and mfa in the basic formatter metadata.
Fixes #137