Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change_object not implemented error #20

Open
quanvuong opened this issue Jun 5, 2022 · 1 comment
Open

change_object not implemented error #20

quanvuong opened this issue Jun 5, 2022 · 1 comment

Comments

@quanvuong
Copy link

quanvuong commented Jun 5, 2022

Thank you for the codebase!

Should this line

pcreader.change_object(cad_path, cad_scale)

be changed to

pcreader._renderer._load_object(cad_path, cad_scale)

because SceneRenderer does not implement change_object function.

Thanks!

@MartinSmeyer
Copy link
Contributor

It's indeed missing and I will add it shortly. For a quick fix you can change this

self._renderer.change_object(cad_path, cad_scale)

to

self._renderer.change_scene([cad_path], [cad_scale], [np.eye(4)]) 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants