Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Ecodata Bottom Temperature Objects and Documentation #161

Open
jcaracappa1 opened this issue Oct 23, 2024 · 6 comments · Fixed by #171
Open

Rename Ecodata Bottom Temperature Objects and Documentation #161

jcaracappa1 opened this issue Oct 23, 2024 · 6 comments · Fixed by #171
Assignees

Comments

@jcaracappa1
Copy link
Contributor

jcaracappa1 commented Oct 23, 2024

Rename bottom temperature objects:
bottom_temp -> bottom_temp_insitu
bottom_temp_comp -> bottom_temp_model_anom
bottom_temp_seasonal_gridded -> bottom_temp_model_gridded
bottom_temp_glorys -> removed
thermal_habitat_area -> thermal_habitat_area
thermal_habitat_persistence -> thermal_habitat_gridded

@BBeltz1 BBeltz1 self-assigned this Oct 23, 2024
@BBeltz1 BBeltz1 moved this from Backlog to ToDo in State of the Ecosystem Oct 23, 2024
@BBeltz1
Copy link
Collaborator

BBeltz1 commented Oct 24, 2024

Other proposed renaming:

  • HMS_species_distribution -> cetacean_shifts
  • seasonal_sst_anomaly_gridded -> surface_temp_anom_gridded
  • seasonal_oisst_anom -> surface_temp_anom

*Note: We could also change seasonal_sst_anomaly_gridded to seasonal_oisst_anom_gridded and leave seasonal_oisst_anom alone.

@BBeltz1
Copy link
Collaborator

BBeltz1 commented Oct 24, 2024

Required Changes

Ecodata

  • Data file
  • Get script
  • Plotting function
  • Documentation
  • Markdown files (e.g. comparison doc)

Catalog

  • "Indicator Name" in issue
  • Bookdown yml
  • 404 Page
  • Issue template dropdowns

Tech Doc

  • Page url
  • Catalog link
  • Bookdown yml
  • Issue template dropdowns

@sgaichas
Copy link
Member

For the sst name changes, I would vote for keeping overall changes to a minimum since there are a lot of downstream effects. So I prefer the option of leaving seasonal_oisst_anom alone and changing the gridded to seasonal_oisst_anom_gridded but I will go with consensus if everyone else wants similar name structures to bottom temp.

For HMS_species_distribution I fully agree with cetacean replacing HMS. Because we talk about both timing shifts and distribution shifts in the report, I would worry that shifts might be too ambiguous. If we want it to be shorter it could be cetacean_dist similar to species_dist or just leave it at cetacean_species_distribution.

@BBeltz1
Copy link
Collaborator

BBeltz1 commented Oct 31, 2024

I think I agree on the sst. For cetacean, I think I prefer cetacean_dist.

@jcaracappa1
Copy link
Contributor Author

I agree with Sarah above

@BBeltz1
Copy link
Collaborator

BBeltz1 commented Oct 31, 2024

Great, thank you both!

@BBeltz1 BBeltz1 linked a pull request Nov 14, 2024 that will close this issue
@SarahJWeisberg SarahJWeisberg moved this from Awaiting Review to Done in State of the Ecosystem Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants