Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New incompatibility: numpy.NaN is deprecated #263

Closed
blychs opened this issue Jul 18, 2024 · 6 comments
Closed

New incompatibility: numpy.NaN is deprecated #263

blychs opened this issue Jul 18, 2024 · 6 comments

Comments

@blychs
Copy link
Collaborator

blychs commented Jul 18, 2024

Hi all,
This might be already enforced by matplotlib<3.9 (I haven't tested that). However, the new numpy 2.0.0 (released a month ago), that was just added to conda-forge, deprecates np.NaN and replaces is by np.nan.
I am still trying to understand which package is really requiring it, I got the error while trying to compile locally the docs in my personal computer (I had it in a cluster before, since I can't compile wrf-python in my local computer due to it being apple silicon).

I will edit this issue when I have more info.

@zmoon
Copy link
Collaborator

zmoon commented Jul 18, 2024

@blychs looks like it was removed for NumPy v2. It should be safe to update all code to use np.nan, which works in NumPy v1 as well.

@blychs
Copy link
Collaborator Author

blychs commented Jul 18, 2024

That's right. However, I just can't find any of our code using it, but building the docs fails with that version of numpy.

@zmoon
Copy link
Collaborator

zmoon commented Jul 18, 2024

MONET has a few (and MONETIO a lot), that could be the issue. Does the traceback show any info about where the error occurred?

@blychs
Copy link
Collaborator Author

blychs commented Jul 18, 2024

When building the docs, I only get that it cannot import driver.py because it cannot find numpy.NaN -which makes sense.
It is likely as you say.
I will finish testing this, hopefully next week at the latest.

@blychs
Copy link
Collaborator Author

blychs commented Aug 20, 2024

Can this be closed @zmoon @rschwant ? I believe that this was fixed at the MONETIO level.

@zmoon
Copy link
Collaborator

zmoon commented Aug 20, 2024

Fine with me. Though, do you want to add some info about this to #266 ?

@blychs blychs closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants