Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the SSL_CTX for QUIC before chroot and privilege drop #1187

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

gthess
Copy link
Member

@gthess gthess commented Nov 22, 2024

For behavioral consistency with the other SSL_CTX creations. Fixes #1185.

  privilege drop, just like the other SSL_CTX creations.
@gthess gthess requested a review from wcawijngaards November 22, 2024 10:58
@gthess gthess self-assigned this Nov 22, 2024
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves the ssl context creation to earlier, and passes the result to the doq connection. The code looks good.

services/listen_dnsport.c Outdated Show resolved Hide resolved
services/listen_dnsport.c Outdated Show resolved Hide resolved
services/listen_dnsport.c Outdated Show resolved Hide resolved
Co-authored-by: Wouter Wijngaards <[email protected]>
@gthess
Copy link
Member Author

gthess commented Dec 3, 2024

Thanks, good catch! I was compiling with support for both ngtcp2 and nghttp2 so it went unnoticed.

@gthess gthess merged commit 61d7250 into master Dec 3, 2024
1 check passed
gthess added a commit that referenced this pull request Dec 3, 2024
- Merge #1187: Create the SSL_CTX for QUIC before chroot and privilege
  drop.
@gthess gthess deleted the doq-sslctx branch December 3, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doq bug
2 participants