Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat request: store extra metadata for writing obs_seq and obs_seq from dataframe #11

Open
hkershaw-brown opened this issue Aug 5, 2024 · 2 comments
Open

Feat request: store extra metadata for writing obs_seq and obs_seq from dataframe #11

hkershaw-brown opened this issue Aug 5, 2024 · 2 comments
Assignees
@hkershaw-brown

Comments

@hkershaw-brown
Copy link
Member

hkershaw-brown commented Aug 5, 2024 •
edited
Loading

e.g. rttov oberservations

  • store meta data on read,
  • metadata written on write
    • obs seq
    • obs seq from dataframe

Currently discarding any obs_def metadata when converting from an obs to a list

pyDARTdiags/src/pydartdiags/obs_sequence/obs_sequence.py

Line 154 in 65c346a

# any observation specific obs def info is between here and the end of the list

@hkershaw-brown hkershaw-brown moved this to Todo in Roadmap to v1 Dec 13, 2024
@hkershaw-brown hkershaw-brown moved this from Backlog to Todo: v1 in Roadmap to v1 Dec 13, 2024
@hkershaw-brown hkershaw-brown self-assigned this Dec 13, 2024
@hkershaw-brown hkershaw-brown moved this from Todo: v1 to In Progress in Roadmap to v1 Dec 13, 2024
@hkershaw-brown
Copy link
Member Author

connected to #20 external forward operators can be thought of as metadata for an observation.

hkershaw-brown added a commit that referenced this issue Dec 16, 2024
@hkershaw-brown
feat: ascii externalFO read and write
c83c85e 
Just storing the externalF0 as metadata, reads each line into an item in the list

issues: #20 #11
I think you can have both obs_def metadata and externalFO
Need to separate?
@hkershaw-brown
Copy link
Member Author

Now reading & writing, as of ea68901
Can close this issue once we have test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkershaw-brown hkershaw-brown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkershaw-brown