Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Undo only restores the last window movement with Preview disabled #643

Closed
3 of 4 tasks
injust opened this issue Dec 27, 2024 · 0 comments · Fixed by #647
Closed
3 of 4 tasks

🐞 Undo only restores the last window movement with Preview disabled #643

injust opened this issue Dec 27, 2024 · 0 comments · Fixed by #647
Assignees
Labels

Comments

@injust
Copy link

injust commented Dec 27, 2024

Bug Description

Let's call this sequence an "action":

  1. Hold down the trigger key(s)
  2. Move the mouse or press a key (or a series of keys for a Cycle)
  3. Release the trigger key(s)

I expected Undo to undo a single action, which means restoring the window to the state before I pressed the trigger key). Instead, Loop only undos the last window movement, even though this is probably not what you want.

This only happens when the Preview is disabled, which means disabling the Preview actually changes the core functionality more than you'd expect.

This happens in a lot of situations:

  1. Using the cycle functionality (Undo reverts to the previous state in the cycle)
  2. Using mouse movement and not hitting the exact direction instantly, or lingering in the middle for too long (causing the window to maximize before snapping, so Undo just maximizes the window)
  3. Simply changing your mind for where you want to snap the window (especially because you can see the window in its new location with Preview disabled)

This is quite surprising to me and I don't think it is desirable behaviour. If this is working as expected, then I think it deserves a setting to configure it.

Steps To Reproduce

  1. Disable Preview
  2. Trigger an example in the description
  3. Try to Undo it

Expected Behavior

Loop should undo an entire action

Actual Behavior

Loop undos a single window movement

Screenshots

No response

macOS Version

Sequoia 15.2

Loop Version

Version 1.1.1 (1259)

Additional Context

No response

Final Checks

  • My issue is written in English
  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
  • I can help with fixing or developing this issue (tick if you can help).
@injust injust added the Bug label Dec 27, 2024
@MrKai77 MrKai77 self-assigned this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants