Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Resetting keybinds only updates the UI after restarting #639

Closed
3 of 4 tasks
injust opened this issue Dec 27, 2024 · 3 comments · Fixed by #646
Closed
3 of 4 tasks

🐞 Resetting keybinds only updates the UI after restarting #639

injust opened this issue Dec 27, 2024 · 3 comments · Fixed by #646
Assignees
Labels

Comments

@injust
Copy link

injust commented Dec 27, 2024

Bug Description

Loop needs to be restarted after resetting keybinds for the new keybinds to reflect in the UI, even though they already work.

Steps To Reproduce

  1. Configure some keybinds
  2. Go to the Advanced section and reset your keybinds
  3. Go back to the Keybindings section -- nothing has changed, but your custom keybinds don't work and the default ones work again

Expected Behavior

The UI should update with the new reset keybinds.

Actual Behavior

The UI still shows the old keybinds.

Screenshots

No response

macOS Version

Sequoia 15.2

Loop Version

Version 1.1.1 (1259)

Additional Context

No response

Final Checks

  • My issue is written in English
  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
  • I can help with fixing or developing this issue (tick if you can help).
@injust injust added the Bug label Dec 27, 2024
@injust injust changed the title 🐞 Importing and resetting keybinds works after restarting Resetting keybinds works after restarting Dec 27, 2024
@injust injust changed the title Resetting keybinds works after restarting Resetting keybinds or importing from Rectangle only works after restarting Dec 27, 2024
@injust injust changed the title Resetting keybinds or importing from Rectangle only works after restarting Resetting keybinds only updates the UI after restarting Dec 27, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Dec 27, 2024

Hey @injust, thanks for all your bug reports/feature requests!!
As for this issue, I believe that the latest development version should fix this, would you be able to update and try again?

@MrKai77 MrKai77 changed the title Resetting keybinds only updates the UI after restarting 🐞 Resetting keybinds only updates the UI after restarting Dec 28, 2024
@MrKai77 MrKai77 linked a pull request Dec 28, 2024 that will close this issue
@MrKai77 MrKai77 self-assigned this Dec 28, 2024
@injust
Copy link
Author

injust commented Dec 28, 2024

Sorry I wasn't able to test sooner! I just updated to 1.2.0 (1383) and this is the behaviour I observed:

  • If I start Loop and go directly to Advanced to reset the keybinds, it reflects immediately
  • If I opened the Keybinds section before resetting them, it only reflects after a restart

Hopefully that aligns with your fix.

@MrKai77
Copy link
Owner

MrKai77 commented Dec 28, 2024

Ah yes so here's an update:
While writing the PR I just merged above, I did notice that the reset button doesn't tell the keybinds tab to refresh. So I fixed that :)
There should be a new development build released reflecting these changes in a few minutes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants