Label filtering matches too much

[Natrium729]

When filtering the label to remove segments, the regex matches the first hyphen it finds, possibly removing parts of the title.

For example, if listening to "Trans-Europa Express - 2009 Remaster" (Kraftwerk) with "remaster" filtered out, the first hyphen matches and the track is displayed as "Trans".

A possible fix (that I haven’t tested) is to replace the first .* in this line of label.js

const filterRegex = new RegExp("(?:-|\\(|\\[).*(?:" + sanitizedInput.replace(",","|") + ").*(?:$|\\)|\\])","gi");

with

[^-\\(\\[]*

that is, a run of something that doesn’t contain hyphens or opening brackets, so that we only match the last hyphen or bracket. (My regex is a bit rusty, I might have made some mistakes.)

Thanks for the extension otherwise! :)

[Moon-0xff]

Ah, yes. I knew about this bug since I added the filtering feature. It is rare enough (on my testing at least) that I never bothered to fix it.
If you can test this yourself and get it working I would very much accept and appreciate a PR for it.

I'm currently not running GNOME personally, so I'm starting to struggle with new additions to the code, but I'll test and check this when I'm able.

[Natrium729]

I do agree it's not really high priority. Still, the filtering feature is really nice and a good idea, and I found the bug in about 1 day of using the extension, so worth fixing I think.

I’ve never dabbled in GNOME extension development, that would be a good opportunity. No promises, but I’ll try to make a PR when I have some time.

[Batwam]

Wouldn't it be preferable to cut at " - " rather than "-" then?